Add icons, tiling strategies, toggle-vertical, and auto tiling direction#1281
Open
craigloewen-msft wants to merge 19 commits intoglzr-io:mainfrom
Open
Add icons, tiling strategies, toggle-vertical, and auto tiling direction#1281craigloewen-msft wants to merge 19 commits intoglzr-io:mainfrom
craigloewen-msft wants to merge 19 commits intoglzr-io:mainfrom
Conversation
* Initial plan * Add windows field to WorkspaceDto for displaying app icons in status bars Co-authored-by: craigloewen-msft <42221804+craigloewen-msft@users.noreply.github.com> * Improve comment clarity for window collection error handling Co-authored-by: craigloewen-msft <42221804+craigloewen-msft@users.noreply.github.com> * WORKING! * Rewrote Rust
Updated
Co-authored-by: craigloewen-msft <42221804+craigloewen-msft@users.noreply.github.com>
Co-authored-by: craigloewen-msft <42221804+craigloewen-msft@users.noreply.github.com>
Co-authored-by: craigloewen-msft <42221804+craigloewen-msft@users.noreply.github.com>
Co-authored-by: craigloewen-msft <42221804+craigloewen-msft@users.noreply.github.com>
Co-authored-by: craigloewen-msft <42221804+craigloewen-msft@users.noreply.github.com>
…n-cache Cache window icon extraction to avoid redundant computation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds 4 different features. I'm sorry for combining them but with my regular bug fixes my git history became intertwined. If they need to be split out to be merged let me know and I can do that. Also happy if these features are not the direction you want to go with the product, mostly I'm filing these to try and contribute back. :). Here are the features:
Add app icons to workspaces
This PR adds icons for open applications to the workspace information at the top of the Window.
Please also see this PR notth4tcold/glaze-wm-zebar#1 in zebar which has required changes as well.
Add tiling strategy
It also adds in 'tiling strategy' to change Window tiling behaviour to be halving instead of sharing, so 3 windows is 50%, 25%, and 25% instead of 33%, 33%, 33%.
Add 'toggle-vertical' command
This command makes a Window toggle between horizontal and vertical, allowing you to easily rearrange windows after they're created.
Add auto tiling direction
Lastly it adds auto tiling direction so that when you open many different Windows it adjusts the split direction to conserve the most screen space (No long skinny windows!)
Related issues
(Self filed): #1223
Also related to PR: #1224