Skip to content

Commit 5632701

Browse files
authored
Moved high bitrate texture tests to engine (flutter#179906)
This adds a few goldens where skia supports the file format. This is a bit more scalable and direct than managing integration tests. ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. If you need help, consider asking for advice on the #hackers-new channel on [Discord]. **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
1 parent 052435c commit 5632701

File tree

17 files changed

+289
-502
lines changed

17 files changed

+289
-502
lines changed

.ci.yaml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -5401,16 +5401,6 @@ targets:
54015401
["devicelab", "ios", "mac"]
54025402
task_name: wide_gamut_ios
54035403

5404-
- name: Mac_ios high_bitrate_images
5405-
recipe: devicelab/devicelab_drone
5406-
presubmit: true
5407-
bringup: true
5408-
timeout: 60
5409-
properties:
5410-
tags: >
5411-
["devicelab", "ios", "mac"]
5412-
task_name: high_bitrate_images_ios
5413-
54145404
- name: Mac_x64_ios hot_mode_dev_cycle_ios__benchmark
54155405
recipe: devicelab/devicelab_drone
54165406
presubmit: false

TESTOWNERS

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,6 @@
7979
/dev/devicelab/bin/tasks/gradient_dynamic_perf__e2e_summary.dart @flar @flutter/engine
8080
/dev/devicelab/bin/tasks/gradient_static_perf__e2e_summary.dart @flar @flutter/engine
8181
/dev/devicelab/bin/tasks/gradle_java8_compile_test.dart @jesswrd @flutter/android
82-
/dev/devicelab/bin/tasks/high_bitrate_images_ios.dart @gaaclarke @flutter/engine
8382
/dev/devicelab/bin/tasks/hot_mode_dev_cycle_linux__benchmark.dart @bkonyi @flutter/tool
8483
/dev/devicelab/bin/tasks/hybrid_android_views_integration_test.dart @gmackall @flutter/android
8584
/dev/devicelab/bin/tasks/image_list_jit_reported_duration.dart @jtmcdole @flutter/engine

dev/devicelab/bin/tasks/high_bitrate_images_ios.dart

Lines changed: 0 additions & 12 deletions
This file was deleted.

dev/devicelab/lib/tasks/integration_tests.dart

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -247,14 +247,6 @@ TaskFunction createWideGamutTest() {
247247
).call;
248248
}
249249

250-
TaskFunction createHighBitrateImagesTest() {
251-
return IntegrationTest(
252-
'${flutterDirectory.path}/dev/integration_tests/high_bitrate_images',
253-
'integration_test/app_test.dart',
254-
createPlatforms: <String>['ios'],
255-
).call;
256-
}
257-
258250
class DriverTest {
259251
DriverTest(
260252
this.testDirectory,

dev/integration_tests/high_bitrate_images/README.md

Lines changed: 0 additions & 10 deletions
This file was deleted.

dev/integration_tests/high_bitrate_images/integration_test/app_test.dart

Lines changed: 0 additions & 107 deletions
This file was deleted.

dev/integration_tests/high_bitrate_images/lib/cpu_sdf_canvas.dart

Lines changed: 0 additions & 154 deletions
This file was deleted.

0 commit comments

Comments
 (0)