Open
Conversation
72a3ffa to
81ad8b4
Compare
|
User stories that are not captured by the current implementation:
What should have been done instead:
|
81ad8b4 to
a24c7c8
Compare
- Unignored `firstname` and `lastname` field in the address model. - Updated validations, attributes, and views to handle 'firstname' and 'lastname' separately. - Modified tests, factories, and locales to align with the new structure. - Introduced a 'set_full_name' method callback to concatenate 'firstname' and 'lastname' for backward compatibility.
Update the address handling logic in the APIs and tests to for 'firstname' and 'lastname' fields, instead of using a single 'name' field.
9655ed5 to
f10964e
Compare
- Update the backend logic to separate 'name', 'firstname' and 'lastname' for better data handling. - Adjusted user and address forms, search functionality, and related views to use the new fields.
Update the address handling logic in the admin components and tests for 'firstname' and 'lastname' fields, instead of using a single 'name' field.
f10964e to
53e1733
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces updates to the address model, admin components, backend, API, and associated logic to handle
firstnameandlastnameas separate fields, replacing the previousnamefield providing backwards compatibility to existing implementations of name. The updates aim to improve data handling and increase clarity when working with user and address-related data.For the purpose of not breaking
nameand provide a smooth transistion if first and last name are used name is compiled with the concatenated value allowing the fields to coexist.Changes:
firstnameandlastnamefields separately in place of thenamefield.nameintofirstnameandlastname, adjusting user and address forms, search functionality, and related views.firstnameandlastnamefields separately, replacing thenamefield.firstnameandlastnamefields in the address model. Introduced aset_full_namemethod for backward compatibility, concatenatingfirstnameandlastname. Updated tests, factories, and locales to align with the new model structure.