Structured data for store/organisation by rahulsingh321 · Pull Request #6 · gms-electronics/solidus

rahulsingh321 · 2025-02-03T20:32:41Z

Store form UI:

fthobe · 2025-02-03T21:26:59Z

@rahulsingh321 translations for labels are entirely missing.
Also here labels are acronyms:
VAT all capitalized as acronym for Value added tax therefor VAT ID
Tax ID not, because tax is not an acronym

rahulsingh321 · 2025-02-04T20:46:19Z

Todos:
1: Address optional in store.
2: Need to add the translation
3: Need to add the test cases.

backend/app/views/spree/admin/stores/_form.html.erb

fthobe · 2025-02-05T16:37:26Z

@kennyadsl we are unsure if using addresses or just make columns here.

Specs by google are following:

The address (physical or mailing) of your organization, if applicable. Include all properties that apply to your country. The more properties you provide, the higher quality the result is for users. You can provide multiple addresses if you have a location in multiple cities, states, or countries.

<html>
  <head>
    <title>About Us</title>
    <script type="application/ld+json">
    {
      "@context": "https://schema.org",
      "@type": "Organization",
      "url": "https://www.example.com",
      "sameAs": ["https://example.net/profile/example1234", "https://example.org/example1234"],
      "logo": "https://www.example.com/images/logo.png",
      "name": "Example Corporation",
      "description": "The example corporation is well-known for producing high-quality widgets",
      "email": "contact@example.com",
      "telephone": "+47-99-999-9999",
      "address": {
        "@type": "PostalAddress",
        "streetAddress": "Rue Improbable 99",
        "addressLocality": "Paris",
        "addressCountry": "FR",
        "addressRegion": "Ile-de-France",
        "postalCode": "75001"
      },
      "vatID": "FR12345678901",
      "iso6523Code": "0199:724500PMK2A2M1SQQ228"
    }
    </script>
  </head>
  <body>
  </body>
</html>

fthobe · 2025-02-05T23:11:31Z

@rahulsingh321 ~~shoot at solidusio/solidus (main) as draft and check if tests fail.~~ see below comment

fthobe · 2025-02-05T23:13:44Z

@rahulsingh321 wait for PR description by me before making pr

fthobe · 2025-02-06T12:00:56Z

@rahulsingh321 please update the screenshot

fthobe

Generally it looks good, some minor things:

try to align the section headers with what they do in the new admin
try to be more consistent with naming throughout a PR

Rest looks good, form is well structured, tests are there. I don't see why this wouldn't be ok. @shahmayur001 needs to remove the wrongly placed commits from here.

core/db/migrate/20250202173007_add_store_attributes_to_spree_stores.rb

backend/app/views/spree/admin/stores/_form.html.erb

api/spec/requests/spree/api/stores_spec.rb

api/lib/spree/api_configuration.rb

backend/app/views/spree/admin/stores/_address_form.html.erb

core/app/models/spree/taxon.rb

core/lib/spree/permitted_attributes.rb

This event fires when the order `#cancel!` event is fired as part of the stock order state machine events. Co-Authored-By: Adam Mueller <adam@super.gd>

This event fires when `OrderCancellations#short_ship` is fired when an an inventory unit is canceled from an order. Co-Authored-By: Adam Mueller <adam@super.gd>

This adds a `:carton_shipped` event that is published whenever `OrderShipping#ship` succeeds to mark a carton as shipped. Co-Authored-By: Adam Mueller <adam@super.gd>

Add new order events

The comment was inconsistent with the default setting. No functional changes have been made.

…onfig [Docs] Fix Meta Data Restriction Comment to reflect default setting

This PR fixes an HTML structure break caused by an unclosed form_tag, ensuring that forms added after using ui/table are rendered correctly. ## Background While customizing the index page to add a new form, I encountered a problem where the added form was not displayed in the browser. Upon investigation, I discovered that the issue stemmed from the form_tag in ui/table/component.html.erb not being explicitly closed, which resulted in subsequent form tags disappearing. ``` rb <%= render component("ui/table/toolbar").new("data-#{stimulus_id}-target": "batchToolbar", role: "toolbar", "aria-label": t(".batch_actions"), hidden: true) do %> <%= form_tag '', id: batch_actions_form_id %> <% @data.batch_actions.each do |batch_action| %> <%= render_batch_action_button(batch_action) %> <% end %> <% end %> ``` Due to the lack of a proper block structure closing the form_tag, the HTML became malformed, and any form tags declared afterward were not rendered. Updated the form_tag to use a block form, ensuring that the opening and closing tags are explicitly defined.

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/textarea In HTML, the initial content of a <textarea> is specified between its opening and closing tags, not as a `value` attribute. Therefore we must set `content`, rather than passing `value` for text areas.

Fix ui/forms/input component for tag: :textarea

…in_admin_table_component [Admin] Fix Unclosed form_tag in table component

…-actions-permission Revert "GH: Allow backport workflow to trigger actions"

This Commit provides the possibility to store legal information in the store resource. Given the wide array of different information required by country, the information stored here provides a baseline for most countries, but might need to be augmented in some jurisdictions. This commit is not meant as legal advisory. Inform yourself about eventual requirements in your country of operation. Some additional information that might be needed: - Legal Representative, - Share Capital of the company, - Contacts for privacy. Schema.org has a schema to markup organizations that has been widely adopted by various search engines: | | https://schema.org/Organization Support / Docs | |--------|-----------------------------------------------------------------------------------| | Bing | https://www.bing.com/webmasters/help/?topicid=cc507c09 | | Google | https://developers.google.com/search/docs/appearance/structured-data/organization | | Yandex | https://yandex.com/support/webmaster/schema-org/what-is-schema-org.html | This update allows to return all organization data on frontend via jsonb if implemented according to schema documentation on a per store basis and edit the data via API and Backend (Old / New). The implemented fields are: - legal_name, - contact_email, - contact_phone, - vat_id, - tax_id, - address1, - address2, - Zip code and city, - state_name, - country_id, - and state_id. Some additional notes regarding the size of the commit: While this commit seems massive in size, no functionality has been added apart from storing the values, no logical changes have been made, hence the commit while bigger in size is simple to analyse. Apart from testing routines, this commit does not contain functional code. Where possible the structure of current address forms has been adopted. Fixes solidusio#6173

fthobe · 2025-03-06T18:42:06Z

@kennyadsl should be good to go.

fthobe · 2025-04-07T10:50:32Z

@kennyadsl could you check again?

github-actions bot added changelog:solidus_core changelog:solidus_api changelog:solidus_backend labels Feb 3, 2025

rahulsingh321 changed the title ~~Structured data for store / organisation~~ Structured data for store/organisation Feb 3, 2025

JustShah reviewed Feb 5, 2025

View reviewed changes

backend/app/views/spree/admin/stores/_form.html.erb Outdated Show resolved Hide resolved

rahulsingh321 force-pushed the 5905-add-store-fields branch from 3a5dad4 to 0ad8199 Compare February 5, 2025 21:38

rahulsingh321 force-pushed the 5905-add-store-fields branch 2 times, most recently from bb18ebd to c31ef6d Compare February 10, 2025 19:37

fthobe requested changes Feb 11, 2025

View reviewed changes

rahulsingh321 force-pushed the 5905-add-store-fields branch 4 times, most recently from 2bdf3fd to 5221825 Compare February 12, 2025 19:21

github-actions bot added the changelog:solidus_legacy_promotions label Feb 12, 2025

rahulsingh321 force-pushed the 5905-add-store-fields branch from 5221825 to 4d128b4 Compare February 17, 2025 19:35

github-actions bot removed the changelog:solidus_legacy_promotions label Feb 17, 2025

rahulsingh321 force-pushed the 5905-add-store-fields branch from 4d128b4 to 747e3ab Compare February 18, 2025 15:12

github-actions bot added changelog:solidus_admin changelog:solidus_promotions changelog:solidus_legacy_promotions changelog:solidus labels Feb 18, 2025

rahulsingh321 force-pushed the 5905-add-store-fields branch from 747e3ab to 5ca04d7 Compare February 20, 2025 14:56

github-actions bot added changelog:solidus_sample and removed changelog:solidus labels Feb 20, 2025

rahulsingh321 force-pushed the 5905-add-store-fields branch 4 times, most recently from c84b99e to bbff7bc Compare February 27, 2025 17:22

github-actions bot removed changelog:solidus_promotions changelog:solidus_legacy_promotions changelog:solidus_sample labels Feb 27, 2025

benjaminwil and others added 4 commits February 28, 2025 11:01

Add :order_canceled event

4085c44

This event fires when the order `#cancel!` event is fired as part of the stock order state machine events. Co-Authored-By: Adam Mueller <adam@super.gd>

Add :order_short_shipped event

1ae5336

This event fires when `OrderCancellations#short_ship` is fired when an an inventory unit is canceled from an order. Co-Authored-By: Adam Mueller <adam@super.gd>

Add :carton_shipped event

003cb78

This adds a `:carton_shipped` event that is published whenever `OrderShipping#ship` succeeds to mark a carton as shipped. Co-Authored-By: Adam Mueller <adam@super.gd>

Merge pull request solidusio#6170 from SuperGoodSoft/new-order-events

d00c324

Add new order events

rahulsingh321 force-pushed the 5905-add-store-fields branch 3 times, most recently from d9c8bdd to 28bd919 Compare March 2, 2025 11:40

fthobe and others added 3 commits March 2, 2025 20:21

Fix Meta Data Restriction Comment to reflect default setting

75751a7

The comment was inconsistent with the default setting. No functional changes have been made.

Merge pull request solidusio#6171 from fthobe/fix-default-meta-data-c…

43b4607

…onfig [Docs] Fix Meta Data Restriction Comment to reflect default setting

rahulsingh321 force-pushed the 5905-add-store-fields branch 3 times, most recently from 76b10b9 to a7fa008 Compare March 3, 2025 17:33

chaimann and others added 2 commits March 3, 2025 18:54

Merge pull request solidusio#6174 from chaimann/fix-textarea-component

7d8a10d

Fix ui/forms/input component for tag: :textarea

rahulsingh321 force-pushed the 5905-add-store-fields branch from a7fa008 to fc8e744 Compare March 4, 2025 07:16

tvdeyen and others added 4 commits March 6, 2025 10:35

Merge pull request solidusio#6172 from swamp09/fix_unclosed_form_tag_…

2d70d96

…in_admin_table_component [Admin] Fix Unclosed form_tag in table component

Revert "GH: Allow backport workflow to trigger actions"

b65baaf

Merge pull request solidusio#6180 from solidusio/revert-6164-backport…

5302932

…-actions-permission Revert "GH: Allow backport workflow to trigger actions"

rahulsingh321 force-pushed the 5905-add-store-fields branch from fc8e744 to a1b1502 Compare March 6, 2025 18:36

Conversation

rahulsingh321 commented Feb 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fthobe commented Feb 3, 2025

Uh oh!

rahulsingh321 commented Feb 4, 2025

Uh oh!

Uh oh!

fthobe commented Feb 5, 2025

Uh oh!

fthobe commented Feb 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

fthobe commented Feb 5, 2025

Uh oh!

fthobe commented Feb 6, 2025

Uh oh!

fthobe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fthobe commented Mar 6, 2025

Uh oh!

fthobe commented Apr 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

rahulsingh321 commented Feb 3, 2025 •

edited

Loading

fthobe commented Feb 5, 2025 •

edited

Loading