Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions core/app/models/spree/taxon.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@

module Spree
class Taxon < Spree::Base
extend FriendlyId
friendly_id :permalink, use: :history, slug_column: :permalink

acts_as_nested_set dependent: :destroy

belongs_to :taxonomy, class_name: 'Spree::Taxonomy', inverse_of: :taxons
Expand All @@ -13,8 +16,7 @@ class Taxon < Spree::Base
has_many :promotion_rule_taxons
has_many :promotion_rules, through: :promotion_rule_taxons

before_create :set_permalink
before_update :set_permalink
before_save :set_permalink
after_update :update_child_permalinks, if: :saved_change_to_permalink?

validates :name, presence: true
Expand Down Expand Up @@ -121,6 +123,24 @@ def permalink_part=(value)
end
end

# override for {FriendlyId::Slugged#should_generate_new_friendly_id?} method,
# to control exactly when new friendly ids are set or updated
def should_generate_new_friendly_id?
permalink_changed? || super
end

# override for {FriendlyId::Slugged#normalize_friendly_id} method,
# to control over the slug format
def normalize_friendly_id(value)
return '' if value.blank?

parts = value.to_s.split('/')
last_word = parts.pop
corrected_last_word = Spree::Config.taxon_url_parametizer_class.parameterize(last_word)

(parts << corrected_last_word).join('/')
end

private

def touch_ancestors_and_taxonomy
Expand Down
24 changes: 24 additions & 0 deletions core/spec/models/spree/taxon_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -269,4 +269,28 @@
end
end
end

context 'stores history of permalinks' do
let(:taxonomy) { create(:taxonomy, name: 'brands') }
let(:root) { taxonomy.root }
let(:taxon_name) { "ruby on rails" }
let(:new_permalink) { "rails for ruby" }
let(:expected_initial_slug) { "brands/ruby-on-rails" }
let(:expected_updated_slug) { "brands/rails-for-ruby" }

let!(:taxon) { create(:taxon, name: taxon_name, parent: root) }

it 'should store the previous slug when permalink is updated' do
expect(taxon.slugs.count).to eq(1)
expect(expected_initial_slug).to eq(taxon.slugs.last.slug)

taxon.update(permalink: new_permalink)

expect(expected_updated_slug).to eq(taxon.permalink)
expect(taxon.slugs.count).to eq(2)

expect(taxon.slugs.pluck(:slug)).to include(expected_initial_slug)
expect(taxon.slugs.pluck(:slug)).to include(expected_updated_slug)
end
end
end
Loading