Skip to content

Fix return type annotations for CellStyle properties in Python API #591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnachman merged 1 commit into from
Feb 24, 2026
Merged

Fix return type annotations for CellStyle properties in Python API #591

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions api/library/python/iterm2/iterm2/screen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ def url(self) -> str:
return self._url.url

@property
def identifier(self) -> str:
def identifier(self) -> typing.Optional[str]:
"""
Returns the optional identifier associated with the URL, if present.

Expand Down Expand Up @@ -172,7 +172,7 @@ def repeats(self) -> int:
return self._proto.repeats

@property
def fg_color(self) -> 'CellStyle.Color':
def fg_color(self) -> typing.Optional['CellStyle.Color']:
"""
Returns the foreground color as a CellStyle.Color object.

Expand All @@ -188,7 +188,7 @@ def fg_color(self) -> 'CellStyle.Color':
return CellStyle.Color(placement=self._proto.fgAlternatePlacementX)

@property
def bg_color(self) -> 'CellStyle.Color':
def bg_color(self) -> typing.Optional['CellStyle.Color']:
"""
Returns the background color as a CellStyle.Color object.

Expand Down