Fix HighlightTrigger.background_color property getter signature#592
Merged
gnachman merged 1 commit intognachman:masterfrom Feb 24, 2026
Merged
Conversation
The @Property getter had a stray `value` parameter copied from the setter, causing TypeError when accessing trigger.background_color.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removed a stray
valueparameter from theHighlightTrigger.background_color@propertygetter. Accessingtrigger.background_colorraisedTypeErrorbecause Python's property descriptor calls the getter with onlyself.Background
value: typing.Optional[iterm2.Color]parameter in placetext_colorproperty does not have this issue-> typing.Optional[iterm2.Color]) to match thetext_colorgetterExample
Verification
Confirmed that
trigger.background_colorreturns the expected value withoutTypeError, andmypy --ignore-missing-imports iterm2/triggers.pyno longer reportsToo many arguments for property [misc]on line 713.