Add _name method to Trigger base class#595
Merged
gnachman merged 3 commits intognachman:masterfrom Mar 2, 2026
Merged
Conversation
Trigger.encode calls self._name() but the base class did not define it, causing AttributeError on unrecognized trigger types returned by decode_trigger.
Verify that: - Trigger base class has _name attribute - Trigger._name() returns "Trigger" - Trigger.encode does not crash on bare Trigger instances - Unrecognized trigger types can round-trip through decode/encode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added a
_namestatic method to theTriggerbase class.Trigger.encodecallsself._name()but the base class did not define it, causingAttributeErroron unrecognized trigger types.Background
Triggersubclasses define@staticmethod _name()returning their class name, but the base class did notdecode_trigger()returns a bareTriggerinstance for unrecognized trigger types (line 79), and calling.encodeon it crashedExample