Fix bugs in Color.from_cocoa and from_legacy_trigger#598
Merged
gnachman merged 2 commits intognachman:masterfrom Mar 2, 2026
Merged
Fix bugs in Color.from_cocoa and from_legacy_trigger#598gnachman merged 2 commits intognachman:masterfrom
Color.from_cocoa and from_legacy_trigger#598gnachman merged 2 commits intognachman:masterfrom
Conversation
…in color.py
- Define MissingDependency as a subclass of ImportError
- Fix int(str) to int(s) in from_legacy_trigger
- Fix return type annotation from ('Color', 'Color') to typing.Tuple
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three bugs in
color.py, all introduced in bda9aec when pyobjc was made optional:MissingDependencyis raised but never defined — added as a subclass ofImportErrorint(str)passes thestrtype instead of the parameters— fixed toint(s)('Color', 'Color')is invalid syntax for mypy — fixed totyping.Tuple[Optional[Color], Optional[Color]]Examples
Color.from_cocoaraisesNameErrorinstead of a meaningful error when pyobjc is not installed:Color.from_legacy_triggeralways raisesTypeErrorbecauseint(str)passes the type object: