Skip to content

Add type annotations to connection.py and keyboard.py #600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnachman merged 1 commit into from
Mar 2, 2026
Merged

Add type annotations to connection.py and keyboard.py #600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/library/python/iterm2/iterm2/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
import typing
import websockets

gDisconnectCallbacks = []
gDisconnectCallbacks: typing.List[typing.Callable[[], None]] = []

# websockets 9.0 moved client into legacy.client and didn't document how to
# migrate to the new API :(. Stick with the old one until I have time to deal
Expand Down
2 changes: 1 addition & 1 deletion api/library/python/iterm2/iterm2/keyboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class Modifier(enum.Enum):
NUMPAD = iterm2.api_pb2.Modifiers.Value("NUMPAD") #: Indicates the key is on the numeric keypad.

@staticmethod
def from_cocoa(value: int) -> ['Modifier']:
def from_cocoa(value: int) -> typing.List['Modifier']:
result = []
if value & (1 << 18):
result.append(Modifier.CONTROL)
Expand Down