Add explicit return None to fg_color and bg_color in screen.py#601
Merged
gnachman merged 1 commit intognachman:masterfrom Mar 2, 2026
Merged
Conversation
The fg_color and bg_color properties dispatch on protobuf oneof fields via if/elif chains but lack an explicit return None when no branch matches. mypy requires an explicit return statement even when the return type is Optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CellStyle.fg_colorandbg_colorproperties dispatch on protobuf oneof fields via if/elif chains but lack an explicitreturn Nonewhen no branch matches. mypy requires an explicit return statement even when the return type isOptional:Added
return Noneafter each if/elif chain.