Fixed Homing state bug#790
Open
doppelhub wants to merge 1 commit intognea:masterfrom
doppelhub:master
Open
Conversation
Fixed an issue where grbl's state machine gets corrupted. For example, if "$H0abc" is sent, existing grbl sets sys.state=STATE_HOMING, but then bails out without actually homing. Subsequent "$H" commands are then not executed, because grbl isn't idle (it still thinks it's homing).
doppelhub
commented
Jan 7, 2020
| case 'H' : // Perform homing cycle [IDLE/ALARM] | ||
| if (bit_isfalse(settings.flags,BITFLAG_HOMING_ENABLE)) {return(STATUS_SETTING_DISABLED); } | ||
| if (system_check_safety_door_ajar()) { return(STATUS_CHECK_DOOR); } // Block if safety door is ajar. | ||
| sys.state = STATE_HOMING; // Set system state variable |
Author
There was a problem hiding this comment.
sys.state set to homing before actually checking if entire line is valid
doppelhub
commented
Jan 7, 2020
| if (system_check_safety_door_ajar()) { return(STATUS_CHECK_DOOR); } // Block if safety door is ajar. | ||
| sys.state = STATE_HOMING; // Set system state variable | ||
| if (line[2] == 0) { | ||
| sys.state = STATE_HOMING; // Set system state variable |
Author
There was a problem hiding this comment.
here sys.state is not set until after syntax is checked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed an issue where grbl's state machine gets corrupted. For example, if "$H0abc" is sent, existing grbl sets sys.state=STATE_HOMING, but then bails out without actually homing. Subsequent "$H" commands are then not executed, because grbl isn't idle (it still thinks it's homing).
Moving sys.state=STATE_HOMING to after the conditional prevents grbl from getting stuck in homing state.