This repository was archived by the owner on Nov 30, 2022. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 373
Verify shopify with SPA #1173
Merged
gnikyt
merged 18 commits into
gnikyt:master
from
enmaboya:feature/verify_shopify_with_spa
Sep 12, 2022
Merged
Verify shopify with SPA #1173
Changes from 12 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
9ad7839
update config, add spa variable
enmaboya cfb1d5f
Continue if app already installed and has access token and not deleted
enmaboya 62158d7
disable cdn app bridge if spa used
enmaboya a5ae5c3
update verify
enmaboya 1dada3f
Merge branch 'master' of github.com:enmaboya/laravel-shopify into fea…
enmaboya 0a89f67
add util helper
enmaboya e246ed8
update validation
enmaboya 3e7297f
add frontend engine enum
enmaboya 365fd34
update frontend validation
enmaboya 7e75aba
add frontend_engine config setting
enmaboya 40a058c
linter fix
enmaboya c52b114
add tests
enmaboya b8ec01a
simplified verification
enmaboya 7c10b93
Fixes issue comparing enum for `useNativeAppBridge` utility method
6c66fb8
Changes test to ensure all tests use app config over Config::set for …
638aeea
Changes test to ensure all tests use app config over Config::set for …
2a1acca
Changes enum/config setup for app bridge configuration to be string b…
325f2c1
Fixes to solve undefined magic method for frontend engine
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
<?php | ||
|
||
namespace Osiset\ShopifyApp\Objects\Enums; | ||
|
||
use Funeralzone\ValueObjects\Enums\EnumTrait; | ||
use Funeralzone\ValueObjects\ValueObject; | ||
|
||
/** | ||
* Online Store 2.0 theme support | ||
*/ | ||
class FrontendEngine implements ValueObject | ||
{ | ||
use EnumTrait; | ||
|
||
/** | ||
* Laravel Blade | ||
* | ||
* @var int | ||
*/ | ||
public const BLADE = 0; | ||
|
||
/** | ||
* Vue.js | ||
* | ||
* @var int | ||
*/ | ||
public const VUE = 1; | ||
|
||
/** | ||
* React | ||
* | ||
* @var int | ||
*/ | ||
public const REACT = 2; | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@enmaboya Switch is probably not needed since its only React we need to look for.
return !$currentFrontendEngine->isSame(FrontendEngine::REACT);
So "if current engine is not React, return true and use app bridge"... React will return false and not use app bridge.