feat(gnoweb): add params:changed

[gfanton]

This PR adds a new params:changed custom event to gnoweb, enabling secure parameter update.

cc @jinoosss

[Gno2D2]

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

• IGNORE the bot requirements for this PR (force green CI check)

Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)
🟢 Changes related to gnoweb must be reviewed by its codeowners

☑️ Contributor Actions:

1. Fix any issues flagged by automated checks.
2. Follow the Contributor Checklist to ensure your PR is ready for review.
   • Add new tests, or document why they are unnecessary.
   • Provide clear examples/screenshots, if necessary.
   • Update documentation, if required.
   • Ensure no breaking changes, or include BREAKING CHANGE notes.
   • Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

• Report a bug with the bot.
• View the bot’s configuration file.

Debug

Automated Checks

Maintainers must be able to edit this pull request (more info)

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: gfanton/gno)

Then

🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request

Changes related to gnoweb must be reviewed by its codeowners

If

🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 A changed file matches this pattern: ^gno.land/pkg/gnoweb/ (filename: gno.land/pkg/gnoweb/frontend/js/controller-action-function.ts)

Then

🟢 Requirement satisfied
└── 🟢 Or
    ├── 🟢 Or
    │   ├── 🔴 And
    │   │   ├── 🔴 Pull request author is user: alexiscolin
    │   │   └── 🔴 This user reviewed pull request: gfanton (with state "APPROVED")
    │   └── 🟢 And
    │       ├── 🟢 Pull request author is user: gfanton
    │       └── 🟢 This user reviewed pull request: alexiscolin (with state "APPROVED")
    └── 🔴 And
        ├── 🟢 Not (🔴 Pull request author is user: alexiscolin)
        ├── 🔴 Not (🟢 Pull request author is user: gfanton)
        └── 🟢 Or
            ├── 🟢 This user reviewed pull request: alexiscolin (with state "APPROVED")
            └── 🔴 This user reviewed pull request: gfanton (with state "APPROVED")

Manual Checks

**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

• Any user with comment edit permission

[jinoosss]

I believe this work will enable seamless integration with the wallet.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[alexiscolin]

I needed to fill in the data-action-function-pkgpath-value in the exec form to make it work.

[alexiscolin]

@jinoosss Is it sufficient to open the wallet when the user clicks the "Submit" button on the form, assuming the Adena extension is installed of course?

I believe the ideal flow would be: the user clicks on submit, and if Adena is installed, the wallet extension opens with the transaction ready to be approved. Perhaps the default gnokey command should blocked and not be displayed?

[jinoosss]

Hi @alexiscolin , I agree with the flow you mentioned.

If the Submit button behaves the same way as navigating to a txlink, Adena wallet can be opened.
However, if you want to handle it with a separate command, Adena can either intercept it or read an additional event.

[alexiscolin]

If the Submit button behaves the same way as navigating to a txlink, Adena wallet can be opened.
However, if you want to handle it with a separate command, Adena can either intercept it or read an additional event.

Hi @jinoosss , actually, it's not a txlink; it's a form (input type="submit") submit event that needs to be blocked by the wallet (the flow I mentioned above). That's why I asked the question :)

gno/gno.land/pkg/gnoweb/frontend/js/controller-form-exec.ts

Line 21 in 9d482a1

private _handleSubmit(event: Event): void {

[jinoosss]

@alexiscolin ,
I understand. I believe Adena can capture the event first and prevent its propagation.