feat(commondao): extension to create callback based proposal definitions by jeronimoalbi · Pull Request #5014 · gnolang/gno

jeronimoalbi · 2025-12-30T16:27:39Z

Adds a gno.land/p/nt/commondao/exts/definition package which is an extension of gno.land/p/nt/commondao that provides an alternative approach for creating custom proposal types.

The main CommonDAO package supports different proposal types though the ProposalDefinition interface, so new proposal types require the definition of a custom type that implements this interface. The Definition type introduced in the new definition extension package is a callback based alternative to the type based approach offered by CommonDAO.

Custom proposal definitions can be created using any of the following public package functions:

// New creates a new custom proposal definition or returns an error
func New(title, body string, options ...Option) (Definition, error)

// MustNew creates a new custom proposal definition or panics on error
func MustNew(title, body string, options ...Option) Definition

Default definition behavior can be configured by using custom options that configures the following proposal parameters:

Custom vote choices
Voting period
Tally behavior
Pre-execution and render validation
Execution behavior

Support defining executable proposal definitions which could be either crossing or non crossing. This is required to be able to define proposal types within pure packages, because crossing methods and functions can only be defined within realms. When a proposal definition is defined in a realm it can implement the crossing execution method, otherwise it must implement non crossing methods. Defining non crossing executable proposal types is useful when the proposal type is defined within a pure package where the definition execution is defined by a crossing callback for example. Technically it would also be possible that a proposal definition just updates local properties on execution, instead of realm state globals.

Gno2D2 · 2025-12-30T16:28:06Z

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):

IGNORE the bot requirements for this PR (force green CI check)

✅ Automated Checks (for Contributors):

🟢 Maintainers must be able to edit this pull request (more info)

☑️ Contributor Actions:

Fix any issues flagged by automated checks.
Follow the Contributor Checklist to ensure your PR is ready for review.
- Add new tests, or document why they are unnecessary.
- Provide clear examples/screenshots, if necessary.
- Update documentation, if required.
- Ensure no breaking changes, or include BREAKING CHANGE notes.
- Link related issues/PRs, where applicable.

☑️ Reviewer Actions:

Complete manual checks for the PR, including the guidelines and additional checks if applicable.

📚 Resources:

Debug

Automated Checks
Maintainers must be able to edit this pull request (more info)
If
🟢 Condition met
└── 🟢 And
    ├── 🟢 The base branch matches this pattern: ^master$
    └── 🟢 The pull request was created from a fork (head branch repo: jeronimoalbi/gno)
Then
🟢 Requirement satisfied
└── 🟢 Maintainer can modify this pull request
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)
If
🟢 Condition met
└── 🟢 On every pull request
Can be checked by

Any user with comment edit permission

jeronimoalbi · 2025-12-30T16:39:15Z

examples/gno.land/p/nt/commondao/README.md

+A proposal can be executable implementing either the **Executable** interface
+or the **CrossExecutable** one as part of the new proposal definition:

 ```go
 type Executable interface {
+    // Execute executes the proposal.
+    Execute() error
+}
+
+type CrossExecutable interface {
    // Execute executes the proposal.
    Execute(realm) error
 }
 ```

+**CrossExecutable** can only be implemented when the proposal definition is
+defined within a realm instead of a package, Gno only allows defining crossing
+functions and methods within realms. So, executable proposal definitions
+defined within packages must implement **Executable** instead, and when
+crossing is required it must be done explicitly within the `Execute()` method.


Updated commondao to allow proposal definitions to be executable without having to be defined as crossing.
This was required to be able to define a proposal definition within a package.

This opens up two possibilities, one is to define new proposal types within realms, as it was the case until now, and the other to define them within a package. When defined within a package crossing must be done explicitly, for example within the Execute() error method.

I don't think this should be supported; or if it is, a proposal should first go through a realm, and then that realm calls the pure package

examples/gno.land/p/nt/commondao/exts/definition/README.md

Co-authored-by: MikaelVallenet <mikael.vallenetpro@gmail.com>

codecov · 2026-01-12T09:05:06Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

thehowl · 2026-02-02T18:32:01Z

examples/gno.land/p/nt/commondao/commondao.gno

+		case Executable:
+			err = e.Execute()
+		case CrossExecutable:
 			err = e.Execute(cross)


I don't think we should add this. Proposals should be assumed to be potentially malicious, so I would always cross-call them. Any specific use case?

thehowl · 2026-02-02T18:33:55Z

examples/gno.land/p/nt/commondao/README.md

+A proposal can be executable implementing either the **Executable** interface
+or the **CrossExecutable** one as part of the new proposal definition:

 ```go
 type Executable interface {
+    // Execute executes the proposal.
+    Execute() error
+}
+
+type CrossExecutable interface {
    // Execute executes the proposal.
    Execute(realm) error
 }
 ```

+**CrossExecutable** can only be implemented when the proposal definition is
+defined within a realm instead of a package, Gno only allows defining crossing
+functions and methods within realms. So, executable proposal definitions
+defined within packages must implement **Executable** instead, and when
+crossing is required it must be done explicitly within the `Execute()` method.


I don't think this should be supported; or if it is, a proposal should first go through a realm, and then that realm calls the pure package

jeronimoalbi added 5 commits December 25, 2025 13:27

docs: add README to CommonDAO package storage extensions

9be802a

feat: add gno.land/p/nt/commondao/exts/proposal package

233f0e1

chore: fix storage extensions package REDME typo

bb08dfb

chore: add QuorumMoreThanHalf constant to commondao package

9f37159

jeronimoalbi self-assigned this Dec 30, 2025

github-project-automation bot added this to 🧙‍♂️Gno.land development and 💪 Bounties & Worx Dec 30, 2025

github-project-automation bot moved this to Triage in 🧙‍♂️Gno.land development Dec 30, 2025

github-actions bot added the 🧾 package/realm Tag used for new Realms or Packages. label Dec 30, 2025

jeronimoalbi commented Dec 30, 2025

View reviewed changes

feat: rename package to gno.land/p/nt/commondao/exts/definition

63a5e53

jeronimoalbi marked this pull request as ready for review December 30, 2025 19:25

jeronimoalbi requested review from Kouteki, ajnavarro, gfanton and moul December 30, 2025 19:26

MikaelVallenet reviewed Jan 2, 2026

View reviewed changes

examples/gno.land/p/nt/commondao/exts/definition/README.md Outdated Show resolved Hide resolved

jeronimoalbi and others added 2 commits January 2, 2026 19:11

chore: fix typo

085cd27

Co-authored-by: MikaelVallenet <mikael.vallenetpro@gmail.com>

Merge branch 'master' into dev/commondao-proposal-extension

792e62e

jeronimoalbi added 2 commits January 15, 2026 14:27

Merge branch 'master' into dev/commondao-proposal-extension

69af557

Merge branch 'master' into dev/commondao-proposal-extension

f9aabac

ajnavarro approved these changes Jan 27, 2026

View reviewed changes

jeronimoalbi added 2 commits January 27, 2026 10:42

Merge branch 'master' into dev/commondao-proposal-extension

9e07ff5

Merge branch 'master' into dev/commondao-proposal-extension

5ca3ddf

jeronimoalbi removed request for Kouteki and moul February 2, 2026 14:14

thehowl reviewed Feb 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(commondao): extension to create callback based proposal definitions#5014

feat(commondao): extension to create callback based proposal definitions#5014
jeronimoalbi wants to merge 12 commits intognolang:masterfrom
jeronimoalbi:dev/commondao-proposal-extension

jeronimoalbi commented Dec 30, 2025 •

edited

Loading

Uh oh!

Gno2D2 commented Dec 30, 2025 •

edited

Loading

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Can be checked by

Uh oh!

jeronimoalbi Dec 30, 2025

Uh oh!

thehowl Feb 2, 2026

Uh oh!

Uh oh!

codecov bot commented Jan 12, 2026

Uh oh!

thehowl Feb 2, 2026

Uh oh!

thehowl Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

jeronimoalbi commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Gno2D2 commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🛠 PR Checks Summary

Manual Checks (for Reviewers):

✅ Automated Checks (for Contributors):

☑️ Contributor Actions:

☑️ Reviewer Actions:

📚 Resources:

If

Then

If

Can be checked by

Uh oh!

jeronimoalbi Dec 30, 2025

Choose a reason for hiding this comment

Uh oh!

thehowl Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Jan 12, 2026

Codecov Report

Uh oh!

thehowl Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

thehowl Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jeronimoalbi commented Dec 30, 2025 •

edited

Loading

Gno2D2 commented Dec 30, 2025 •

edited

Loading