fix(gnovm): handle ptr dereferences in ptr to arrays#5166
Open
thehowl wants to merge 2 commits intognolang:masterfrom
Open
fix(gnovm): handle ptr dereferences in ptr to arrays#5166thehowl wants to merge 2 commits intognolang:masterfrom
thehowl wants to merge 2 commits intognolang:masterfrom
Conversation
Collaborator
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
omarsy
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks to v01t4ire on hackenproof for the bug report. This fixes a bug whereby slice and range operations on pointers to array could cause an unrecoverable nil pointer dereference. This PR adds the proper nil checks to ensure they create a normal panic, as other cases where we dereference a pointer.
One of the testcases had an issue whereby GetLine would return 0 and cause another panic when generating a stacktrace, so a small fix in machine.go was in order.