Merged
Conversation
AryanGodara
reviewed
Mar 11, 2026
Member
AryanGodara
left a comment
AryanGodara
left a comment
There was a problem hiding this comment.
From the cargo.toml, we can now remove
base64, hmac, moka, and sha2 as they're not being used now 👀
Member
...
test tests::dex::partial_fill::market ... FAILED
test tests::dex::partial_fill::insufficient_room_for_surplus_fee ... FAILED
failures:
failures:
tests::balancer::market_order::buy_v2
tests::balancer::market_order::sell_v2
tests::dex::partial_fill::insufficient_room_for_surplus_fee
tests::dex::partial_fill::marketThese 4 tests are failing on this branch, as well as on main branch for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OKX solver was migrated to another repo cowprotocol/services#4236. This PR cleans up the current repository.