Merged
Conversation
Remove the `axum-tracing` feature from the `observe` dependency as it was removed upstream in cowprotocol/services#4067. The `tracing_axum` module is now unconditionally compiled starting from v2.346.0. This unblocks the automated update-cow-dependencies CI workflow which fails on any tag >= v2.346.0 because the feature no longer exists.
Adapt to breaking changes in the services monorepo: - observe: module paths reorganized - distributed_tracing::tracing_axum -> tracing::distributed::axum - tracing::initialize_reentrant -> tracing::init::initialize_reentrant - ethrpc: Web3 struct simplified - .alloy field renamed to .provider - web3() now takes 3 args (Config, &Url, Option<&str>) - rate_limit::Strategy moved to configs::rate_limit::Strategy - dto::solution::Solutions replaced by SolverResponse enum - axum 0.6 -> 0.8 (Server removed, use TcpListener + axum::serve) - reqwest 0.11 -> 0.12, hyper 0.14 -> 1, tower-http 0.4 -> 0.6 - bigdecimal 0.3 -> 0.4, prometheus-metric-storage 0.5 -> 0.6
squadgazzz
changed the title
Bump reqwest 0.12 -> 0.13, tower 0.4 -> 0.5, itertools 0.11 -> 0.14, toml 0.7 -> 0.8 to match cowprotocol/services workspace versions.
- Update wildcard route syntax from `/*path` to `/{*path}` (axum 0.8)
- Use `to_plain_string()` for BigDecimal serialization to avoid
scientific notation introduced in bigdecimal 0.4
AryanGodara
approved these changes
Mar 26, 2026
Member
AryanGodara
left a comment
AryanGodara
left a comment
There was a problem hiding this comment.
LGTM. Build fine, tests and lint all pass (after cloning branch locally).
Also went through the code changes. Looks ok 👌🏼
m-sz
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
v2.345.4tov2.354.3axum-tracingfeature from theobservedependency — removed upstream in cowprotocol/services#4067observemodule paths reorganized (distributed_tracing->tracing::distributed,tracing::initialize_reentrant->tracing::init::initialize_reentrant)ethrpc::Web3struct simplified (.alloy->.provider,web3()signature changed)rate_limit::Strategymoved toconfigs::rate_limit::Strategydto::solution::Solutionsreplaced bySolverResponseenumaxum0.6 -> 0.8 (Serverremoved, now usesTcpListener+axum::serve, wildcard routes/*path->/{*path})bigdecimal0.3 -> 0.4 (useto_plain_string()to avoid scientific notation in serialization)prometheus-metric-storage0.5 -> 0.6,prometheus0.13 -> 0.14reqwest0.11 -> 0.13,hyper0.14 -> 1,tower0.4 -> 0.5,tower-http0.4 -> 0.6itertools0.11 -> 0.14,toml0.7 -> 0.8How to test
Existing test + staging