Skip to content
This repository was archived by the owner on Jan 21, 2026. It is now read-only.

complete PVSS refatoring & circuit connections#43

Merged
0xjei merged 53 commits intotrbfv-bfvfrom
connect-circuits
Jan 16, 2026
Merged

complete PVSS refatoring & circuit connections#43
0xjei merged 53 commits intotrbfv-bfvfrom
connect-circuits

Conversation

@0xjei
Copy link
Member

@0xjei 0xjei commented Dec 17, 2025

@0xjei 0xjei self-assigned this Dec 17, 2025
@0xjei 0xjei marked this pull request as ready for review December 19, 2025 17:08
@0xjei
Copy link
Member Author

0xjei commented Jan 10, 2026

okay, I am considering the refactoring completed. I am going to update the generator based on the latest changes we had in order to generate example witnesses and have everything for running benchmarks.

put everyone as reviewers just to give any other feedbacks you might have on code here. Remember, I am planning to do a copy & paste on enclave circuits folder at the end (yes, we are missing docs and aggregation but they will be tackled in another pr).

we are dealing with C2b where smudging noise shares for production parameter set exceeds the U128 mod. Therefore, we are implementing them with Big Numbers mod arithmentic 9296ca3 but getting some problems with circuit dimension. Hope to get more answers soon.

@0xjei
Copy link
Member Author

0xjei commented Jan 13, 2026

okay, I am considering the refactoring completed. I am going to update the generator based on the latest changes we had in order to generate example witnesses and have everything for running benchmarks.
put everyone as reviewers just to give any other feedbacks you might have on code here. Remember, I am planning to do a copy & paste on enclave circuits folder at the end (yes, we are missing docs and aggregation but they will be tackled in another pr).

we are dealing with C2b where smudging noise shares for production parameter set exceeds the U128 mod. Therefore, we are implementing them with Big Numbers mod arithmentic 9296ca3 but getting some problems with circuit dimension. Hope to get more answers soon.

fixed in 035d8c7 - amazing catch by @zahrajavar

Copy link
Member

@cedoor cedoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@0xjei 0xjei merged commit ce1cda6 into trbfv-bfv Jan 16, 2026
3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants