[build] Require C++17 as minimal#354
Merged
qmfrederik merged 1 commit intognustep:masterfrom Nov 3, 2025
Merged
Conversation
3 tasks
b98f76f to
a590fa1
Compare
Signed-off-by: Uilian Ries <uilianries@gmail.com>
a590fa1 to
049dbf6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
When building libobjc2 on the Pull Request conan-io/conan-center-index#27957, it's possible to see that the project is locked to use C++17 always, and does not allow using newer C++ standards like C++20 or C++23.
This PR replaces the locked
CMAKE_CXX_STANDARDwithtarget_compile_features, so C++17 is still required as minimal.I can build libobjc2 with C++23 without problems:
Regards!