Skip to content

Fix close button for wayland#57

Closed
pkgdemon wants to merge 1 commit intognustep:masterfrom
gershwin-desktop-legacy:master
Closed

Fix close button for wayland#57
pkgdemon wants to merge 1 commit intognustep:masterfrom
gershwin-desktop-legacy:master

Conversation

@pkgdemon
Copy link
Contributor

No description provided.

@pkgdemon pkgdemon requested a review from fredkiefer as a code owner June 11, 2025 16:48
@fredkiefer
Copy link
Member

I don't understand, why this change is needed. Is it because of the resize code just a bit below? If so, we rather have this new code included there. The close button should just work as any other button.
If we really need this code or something similar, could you please make sure to add a space after each colon in a method call? Thank you.

@pkgdemon
Copy link
Contributor Author

pkgdemon commented Jun 16, 2025

Thanks Fred. Yes I will make the changes. With the Wayland server this code allows the close button to function when building libs-back with Wayland configured. The close button does not function without it when launching GNUstep apps in a Wayland compositor. Minimize is also broken which I have code to fix also but I was going to follow up with another PR after seeing what changes would be needed for this one.

@pkgdemon pkgdemon marked this pull request as draft June 17, 2025 02:48
@pkgdemon pkgdemon marked this pull request as ready for review June 17, 2025 02:53
@pkgdemon
Copy link
Contributor Author

Hi @fredkiefer take a look now when you can. I think you will like this much better as I do. I have confirmed it still works to close the window.

@fredkiefer
Copy link
Member

Thank you for adding the spaces after the colons.
Both this change still looks odd to me. We should not need to have any special code here. To me this looks like the code for resizing is eating up the button pressed event. If that is the case, we should just exclude the button frames from being passed on as resize events.

@pkgdemon
Copy link
Contributor Author

Thank you for adding the spaces after the colons. Both this change still looks odd to me. We should not need to have any special code here. To me this looks like the code for resizing is eating up the button pressed event. If that is the case, we should just exclude the button frames from being passed on as resize events.

I suspect you may be right. Let me look into this further. Thanks.

@pkgdemon
Copy link
Contributor Author

I think it may take some time before I can get back to this fully. I've kind of lost interest in wayland at the moment and I'm deeper into dbuskit things. We can close for now if you like @fredkiefer and I can reopen in the future if you want.

@pkgdemon pkgdemon closed this Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants