*: make CI green again #146
Conversation
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
|
Allocation APIs have been changing rapidly since the end of January. I suggest to merge it first to make it build and test in stable channel and then fix alloc_trait feature when rapid refactor from wg-allocators finish. |
This reverts commit 18ee69f. Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
i686-apple-darwin is removed from nightly and beta. Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Upstream doesn't guarantee configure file matches across platform and versions. Checking configure file can fail easily. Signed-off-by: Jay Lee <[email protected]>
BusyJay
force-pushed
the
make-ci-green
branch
3 times, most recently
from
ca62133 to
68f4419
Compare
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
|
@gnzlbg The only one left is the config diff. I don't know what's the purpose of the check and have no clue what's the proper way to fix it. Any suggestions? |
|
It checks that the version of the configure script that autoconf produces matches what's checked in here: https://github.com/gnzlbg/jemallocator/tree/master/jemalloc-sys/configure. You should just need to update that file. |
|
But the check passes on MacOS but fail on Linux. I'm afraid updating it will just fix one and break the other. |
Signed-off-by: Jay Lee <[email protected]>
Signed-off-by: Jay Lee <[email protected]>
|
@sfackler I followed your suggestion, and it did break MacOS build. I'm going to disable the check for now. |
Signed-off-by: Jay Lee <[email protected]>
2 participants
This PR fixes several compilation warnings and skip function pointer for ctests.
I hope this can be a step to merging #130.