Cache config value to optimize Get config API#151
Open
x-xy-y wants to merge 6 commits intogo-chassis:masterfrom
Open
Cache config value to optimize Get config API#151x-xy-y wants to merge 6 commits intogo-chassis:masterfrom
x-xy-y wants to merge 6 commits intogo-chassis:masterfrom
Conversation
x-xy-y
force-pushed
the
feature/cache-config-value
branch
from
43bf549 to
ad88741
Compare
Member
|
先把圈复杂度的检查去掉吧，这个工具肯定又出问题了 |
|
|
||
| func createFile(content string, name string, dir string) string { | ||
| filename := filepath.Join(dir, name) | ||
| f1, _ := os.Create(filename) |
Member
There was a problem hiding this comment.
Go的UT已经支持临时目录特性了，不需要再这么创建，可以参考下，少维护一些代码
Author
There was a problem hiding this comment.
go 1.13 不支持 t.TempDir ，我们需要支持 go 1.13, 这个不改吧
Member
There was a problem hiding this comment.
出自 https://go.dev/doc/devel/release
go的版本策略，为了你们的安全考虑，我不建议使用低于1.5及以下的版本，没有安全保障
Author
There was a problem hiding this comment.
实际的业务不可能是跟着 go 官方的节奏走，总会有一些版本比较落后。就算业务有意愿，各种三方库也有大量跟不上的。而且这里的并不需要做多大的修改，就能够都支持到的，何苦一定要改呢
tianxiaoliang
requested changes
Dec 25, 2021
added 2 commits
December 28, 2021 17:33
Member
得删掉这部分，门禁才能过 |
source/manager.go
Outdated
| } else { | ||
| m.ConfigurationMap.Store(e.Key, source.GetSourceName()) | ||
| srcName := source.GetSourceName() | ||
| // fixme: |
Member
There was a problem hiding this comment.
这个看上去改变了程序过去的行为。可否用过archaius框架级的bool作为功能开关，控制get时是否从缓存取值
Author
|
上回提到事件更新行为一直都有不能保证最终一致的问题 在目前的 master 上，(加上 mem source 的 Delete 修改) 运行 consistencytest， 可以比较容易复现配置无法保证最终一致的问题. 在修改了 updateEvent 机制的 feature/cache-config-value 分支上, consistencytest 可以 pass master 上的失败信息 |
Member
|
cyclo检查失败了，把这个检查步骤干掉吧 |
Author
我删掉了 cyclo , 再看看？ |
Member
|
可以推送到新的banch vx.x.x.beta |
Author
我应该是没有权限直接推送到这个库的。能做的是创建 Pull Request . 但也不存在一个 vx.x.x.beta 的分支给我选择。是不是你要先建一下这个分支
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
读配置的过程， 前后要经过好多次锁，而且会受 source 实现影响。改为直接缓存当前的配置值，读取时从当前缓存读。
修改前：
修改后：