Conversation
|
Yes please, this brings issues! |
|
@plutov Heya! Just had a look and you had the same issue I had, but i did get the tests working in the end 🙈 I fixed it by this replacement :) - // NewSignatureAlgorithm creates a new SignatureAlgorithm object with the given name.
- jwa.NewSignatureAlgorithm
+ // LookupSignatureAlgorithm returns the SignatureAlgorithm object for the given name.
+ jwa.LookupSignatureAlgorithm |
- Upgrade Go version to 1.24.3 - Update lestrrat-go/jwx/v3 to version 3.0.2 - Upgrade golang.org/x/crypto to version 0.38.0 and golang.org/x/sys to version 0.33.0 - Refactor JWT claim extraction in jwtauth.go and jwtauth_test.go to use transform.AsMap for improved readability and error handling.
|
@kw510 please also change the version in the example file. |
VojtechVitek
left a comment
VojtechVitek
left a comment
There was a problem hiding this comment.
Looks good! Minor feedback
Thank you 👍
- Downgrade Go version in go.mod to 1.23.0 - Update RSA private and public keys in jwtauth_test.go for improved security and compatibility - Adjust token string in TestSimpleRSAVerifyOnly for consistency
|
@VojtechVitek @kw510 let's merge it ? ;) |
VojtechVitek
left a comment
VojtechVitek
left a comment
There was a problem hiding this comment.
LGTM. Thank you.
Let me test this some more before we merge 👍
Can anyone else help test this PR?
|
Hey @VojtechVitek I tested it on a project where it was originally failing, but now it works well. Looks good from my side! |
|
@VojtechVitek how is testing going? Why this merge takes so long? |
|
Same question as @plutov: I've been holding off updating some libraries because of this PR. What's the status? |
|
Any progress on this? Can we help? |
|
hey folks, @kw510 , @VojtechVitek , @plutov has this been tested already? It’s starting to become a bit of a pain. If you have any updates or a rough plan for when it might be released, I’d really appreciate it. |
|
@kosmoz @orchowski @hacdias can you help me test this change?
Once confirmed, I'll go ahead and merge. |
I had to add this to my I did a quick test on https://github.com/distr-sh/distr and it worked (after updating jwx to v3, obviously) |
|
Seems to work! |
|
Also works |
6 participants
Update dependencies to use v3 of lestrrat-go/jwx and related packages
Refactor JWT handling in tests and main code for compatibility with new API.