creating a new slice in several job options because appending modifies original#809
Merged
JohnRoesler merged 2 commits intov2from Jan 3, 2025
Merged
creating a new slice in several job options because appending modifies original#809JohnRoesler merged 2 commits intov2from
JohnRoesler merged 2 commits intov2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
The original slices passed into the functions were being modified, leading to undesirable results!
Which issue(s) does this PR fix/relate to?
Resolves #807
List any changes that modify/break current functionality
Have you included tests for your changes?
TODO - add tests that fail before the changes, and pass after. This should be doable by calling the function more than once.
Did you document any new/modified functionality?
example_test.goREADME.mdNotes