fixes related to the bug where a job unexpectedly runs twice#810
Merged
JohnRoesler merged 2 commits intov2from Jan 29, 2025
Merged
fixes related to the bug where a job unexpectedly runs twice#810JohnRoesler merged 2 commits intov2from
JohnRoesler merged 2 commits intov2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Addresses edge cases that could result in a job running twice unexpectedly.
There are reports of jobs being run very close together when they should not be -> #789.
What this fixes:
next()functions, thenanosecondtime values were being included inconsistently on the day calculations. SinceAtTimeonly considers hour, min, sec, there is risk in including the nanosecond values, as I could see it resulting in next run values being incorrect. Instead, just anchoring to zero nanoseconds.nextScheduledslice. Since this is used to schedule from, having a duplicate value could result in the same time being set for the job to runWhich issue(s) does this PR fix/relate to?
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
example_test.goREADME.mdNotes