feat(event listener): introduce BeforeJobRunsSkipIfBeforeFuncErrors as a new Eventlistener#813
Merged
JohnRoesler merged 1 commit intogo-co-op:v2from Jan 9, 2025
FalcoSuessgott:v2
Merged
feat(event listener): introduce BeforeJobRunsSkipIfBeforeFuncErrors as a new Eventlistener#813JohnRoesler merged 1 commit intogo-co-op:v2from FalcoSuessgott:v2
JohnRoesler merged 1 commit intogo-co-op:v2from
FalcoSuessgott:v2
Conversation
JohnRoesler
reviewed
Jan 8, 2025
JohnRoesler
reviewed
Jan 8, 2025
JohnRoesler
reviewed
Jan 8, 2025
JohnRoesler
reviewed
Jan 8, 2025
JohnRoesler
reviewed
Jan 9, 2025
Contributor
JohnRoesler
left a comment
There was a problem hiding this comment.
Last thing, can you add an example to the example test file?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
This PR adds a new
EventListenerBeforeJobRunsSkipIfBeforeFuncErrorsthat exits job execution if the provided func returns an errorUse Case:
Im using
gocronas a command wrapper forterraformto perform synthetic monitoring checks and came up with a configuration as follows:Where as the commands specified in the
before_scriptblock would be passed toBeforeJobRuns(), without this PR there was no way to stop the currents jobs execution in case of an error in any of the commands inbefore_script.Introducing
BeforeJobRunsSkipIfBeforeFuncErrorsallows me to exit the jobs execution gracefully and reschedule to job after the given interval.List any changes that modify/break current functionality
noneHave you included tests for your changes?
Si
Did you document any new/modified functionality?
example_test.goREADME.mdNotes