removes nextRuns in the past when job skipped by locker #828#829
Merged
JohnRoesler merged 2 commits intogo-co-op:v2from Feb 17, 2025
manuelarte:fix-next-run-locker
Merged
removes nextRuns in the past when job skipped by locker #828#829JohnRoesler merged 2 commits intogo-co-op:v2from manuelarte:fix-next-run-locker
JohnRoesler merged 2 commits intogo-co-op:v2from
manuelarte:fix-next-run-locker
Conversation
Contributor
Author
|
Some somments: I added a new channel to "update" the I decided to create a new channel, but maybe it makes sense to modify the method Or any other solution that I don't see right now. What do you guys think? |
Contributor
|
hey @manuelarte I considered a few options, and without changing any other behavior, this seems like a reasonable route to go. Thanks for digging in and putting forth a fix. |
JohnRoesler
approved these changes
Feb 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
It proposes a possible solution for the bug described in #828
Which issue(s) does this PR fix/relate to?
Resolves #828
List any changes that modify/break current functionality
no breaking of current functionality
Have you included tests for your changes?
Will include them after we agree on the solution
Did you document any new/modified functionality?
example_test.goREADME.mdNotes