fix: limit validation for WithLimitedRuns#893
Merged
JohnRoesler merged 2 commits intogo-co-op:v2from Nov 5, 2025
Merged
Conversation
JohnRoesler
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this do?
Add limit validation for
WithLimitedRunsWhich issue(s) does this PR fix/relate to?
Resolves #892
List any changes that modify/break current functionality
WithLimitedRuns(0)previously created an unlimited job silentlyNo breaking change for correct usage (limit ≥ 1 unchanged)
Breaks only invalid config (limit=0) — which was a silent bug before
Have you included tests for your changes?
Yes
Did you document any new/modified functionality?
example_test.goREADME.md