-
Notifications
You must be signed in to change notification settings - Fork 51
Update embedfs implementation #137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@this-kirke thanks for proposing these changes. Please take a look at the feedback below.
0f56f9c
to
6ad6516
Compare
Hi Paulo! Thank you for the review. I've updated with requested changes; all tests pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@this-kirke Thanks for the follow up. I just did a full review now, there are a few tests that are redundant which we can remove. But otherwise it LGTM.
Please squash your commits once you are done with the changes below.
Thank you for the detailed review! I agree on all points. I think everything should be resolved now; please let me know if there's anything else you notice. We can squash on complete. |
- Add chroot functionality to embedfs using billy's chroot helper, enabling compatibility with filesystem operations that require path isolation - Fix path normalization to support billy's absolute path convention - Implement Lstat method - Additional tests to cover embedfs implementation
5cb6e4d
to
b89ce64
Compare
Fixes to embedfs implementation:
Additional test coverage:
Test infrastructure:
The embedfs implementation now provides billy.Filesystem compliance for read-only embedded filesystems.