Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds umask support to the memfs filesystem implementation, enabling consistent file mode handling across go-git operations. The umask defaults to 0o022 (standard POSIX behavior) and can be customized via a new WithUmask() option.
Key Changes:
- Introduced umask support with configurable
WithUmask()option and default value of 0o022 - Added
Chmodcapability to the polyfill helper to support file mode changes - Implemented comprehensive test coverage for umask behavior across file/directory creation and chmod operations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| memfs/memory_option.go | Defines the WithUmask option function and adds umask field to options struct |
| memfs/memory.go | Implements umask application logic via applyUmask() method and integrates it into file/directory creation operations |
| memfs/memory_test.go | Adds comprehensive test cases validating umask behavior for various scenarios including default/custom umask values, OpenFile operations, Chmod, and root directory handling |
| helper/polyfill/polyfill.go | Extends polyfill with Chmod capability support to enable file permission modifications |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
pjbgf
force-pushed
the
memfm
branch
7 times, most recently
from
3c8cef9 to
10cff82
Compare
The umask construct is now supported via new WithUMask(value) option. When not set it defaults to 0o022, as per generally used within posix systems. The polyfill had to be changed to add support for Chmod, without that the new TestUmaskChmod would simply fail to alter filemode of existing files. Signed-off-by: Paulo Gomes <pjbgf@linux.com>
Signed-off-by: Paulo Gomes <pjbgf@linux.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The umask construct is now supported via new WithUMask(value) option. When not set it defaults to 0o022, as per generally used within posix systems.
The polyfill had to be changed to add support for Chmod, without that the new TestUmaskChmod would simply fail to alter filemode of existing files.
This will enable consistent file mode results during go-git operations across all built-in filesystems.
Follow-up from #171.