add tests

Author: wxiaoguang

models/db/engine.go

@@ -134,6 +134,9 @@ func SyncAllTables() error {
 func InitEngine(ctx context.Context) error {
 	xormEngine, err := newXORMEngine()
 	if err != nil {
+		if strings.Contains(err.Error(), "SQLite3 support") {
+			return fmt.Errorf(`sqlite3 requires: -tags sqlite,sqlite_unlock_notify%s%w`, "\n", err)
+		}
 		return fmt.Errorf("failed to connect to database: %w", err)
 	}
 

models/migrations/base/tests.go

@@ -18,7 +18,7 @@ import (
 	"code.gitea.io/gitea/modules/setting"
 	"code.gitea.io/gitea/modules/testlogger"
 
-	"github.com/stretchr/testify/assert"
+	"github.com/stretchr/testify/require"
 	"xorm.io/xorm"
 )
 
@@ -33,15 +33,15 @@ func PrepareTestEnv(t *testing.T, skip int, syncModels ...any) (*xorm.Engine, fu
 	ourSkip := 2
 	ourSkip += skip
 	deferFn := testlogger.PrintCurrentTest(t, ourSkip)
-	assert.NoError(t, unittest.SyncDirs(filepath.Join(filepath.Dir(setting.AppPath), "tests/gitea-repositories-meta"), setting.RepoRootPath))
+	require.NoError(t, unittest.SyncDirs(filepath.Join(filepath.Dir(setting.AppPath), "tests/gitea-repositories-meta"), setting.RepoRootPath))
 
 	if err := deleteDB(); err != nil {
-		t.Errorf("unable to reset database: %v", err)
+		t.Fatalf("unable to reset database: %v", err)
 		return nil, deferFn
 	}
 
 	x, err := newXORMEngine()
-	assert.NoError(t, err)
+	require.NoError(t, err)
 	if x != nil {
 		oldDefer := deferFn
 		deferFn = func() {

models/migrations/v1_23/v310.go

@@ -10,16 +10,16 @@ import (
 	"xorm.io/xorm"
 )
 
-type WebAuthnCredential struct {
+type WebAuthnCredential310 struct {
 	CredentialFlags string `xorm:"TEXT DEFAULT ''"`
 }
 
-func (cred WebAuthnCredential) TableName() string {
+func (cred WebAuthnCredential310) TableName() string {
 	return "webauthn_credential"
 }
 
 func AddFlagsOnWebAuthnCredential(x *xorm.Engine) error {
-	if err := x.Sync(new(WebAuthnCredential)); err != nil {
+	if err := x.Sync(new(WebAuthnCredential310)); err != nil {
 		return err
 	}
 

models/migrations/v1_23/v310_test.go

@@ -0,0 +1,53 @@
+// Copyright 2023 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package v1_23 //nolint
+
+import (
+	"testing"
+
+	"code.gitea.io/gitea/models/migrations/base"
+
+	"github.com/stretchr/testify/require"
+)
+
+type WebAuthnCredentialOld struct {
+	ID int64 `xorm:"pk autoincr"`
+}
+
+func (cred WebAuthnCredentialOld) TableName() string {
+	return "webauthn_credential"
+}
+
+func TestAddFlagsOnWebAuthnCredential(t *testing.T) {
+	x, deferable := base.PrepareTestEnv(t, 0, new(WebAuthnCredentialOld))
+	defer deferable()
+
+	_, err := x.Exec("INSERT INTO webauthn_credential (id) VALUES (1)")
+	require.NoError(t, err)
+	_, err = x.Exec("INSERT INTO webauthn_credential (id) VALUES (2)")
+	require.NoError(t, err)
+
+	require.NoError(t, AddFlagsOnWebAuthnCredential(x))
+
+	getFlags := func() (s1, s2 string) {
+		x.Select("credential_flags").Table("webauthn_credential").Where("id=1").Get(&s1)
+		x.Select("credential_flags").Table("webauthn_credential").Where("id=2").Get(&s2)
+		return s1, s2
+	}
+
+	s1, s2 := getFlags()
+	require.Equal(t, `{"userPresent":false,"userVerified":false,"backupEligible":true,"backupState":false}`, s1)
+	require.Equal(t, `{"userPresent":false,"userVerified":false,"backupEligible":true,"backupState":false}`, s2)
+
+	_, err = x.Table("webauthn_credential").Where("id=1").Update(map[string]any{"credential_flags": `{}`})
+	require.NoError(t, err)
+	s1, s2 = getFlags()
+	require.Equal(t, `{}`, s1)
+	require.Equal(t, `{"userPresent":false,"userVerified":false,"backupEligible":true,"backupState":false}`, s2)
+
+	require.NoError(t, AddFlagsOnWebAuthnCredential(x))
+	s1, s2 = getFlags()
+	require.Equal(t, `{}`, s1)
+	require.Equal(t, `{"userPresent":false,"userVerified":false,"backupEligible":true,"backupState":false}`, s2)
+}