add more comments

Author: wxiaoguang

routers/web/repo/issue_list.go

@@ -504,7 +504,7 @@ func issues(ctx *context.Context, milestoneID, projectID int64, isPullOption opt
 	if !util.SliceContainsString(types, viewType, true) {
 		viewType = "all"
 	}
-
+	// TODO: "assignee" should also use GetFilterUserIDByName in the future to support usernames directly
 	assigneeID := ctx.FormInt64("assignee")
 	posterUsername := ctx.FormString("poster")
 	posterUserID := shared_user.GetFilterUserIDByName(ctx, posterUsername)

routers/web/shared/user/helper.go

@@ -30,7 +30,8 @@ func MakeSelfOnTop(doer *user.User, users []*user.User) []*user.User {
 // GetFilterUserIDByName tries to get the user ID from the given username.
 // Before, the "issue filter" passes user ID to query the list, but in many cases, it's impossible to pre-fetch the full user list.
 // So it's better to make it work like GitHub: users could input username directly.
-// Old usage: poster=123, new usage: poster=the-user-name (at the moment, non-existing username is treated as poster=0)
+// Since it only converts the username to ID directly and is only used internally (to search issues), so no permission check is needed.
+// Old usage: poster=123, new usage: poster=the-username (at the moment, non-existing username is treated as poster=0, not ideal but acceptable)
 func GetFilterUserIDByName(ctx context.Context, name string) int64 {
 	if name == "" {
 		return 0

routers/web/user/home.go

@@ -444,6 +444,7 @@ func buildIssueOverview(ctx *context.Context, unitType unit.Type) {
 	// In the future, we need something like github: "author:user1" to accept usernames directly.
 	posterUsername := ctx.FormString("poster")
 	opts.PosterID = user.GetFilterUserIDByName(ctx, posterUsername)
+	// TODO: "assignee" should also use GetFilterUserIDByName in the future to support usernames directly
 	opts.AssigneeID, _ = strconv.ParseInt(ctx.FormString("assignee"), 10, 64)
 
 	isFuzzy := ctx.FormBool("fuzzy")
@@ -583,9 +584,10 @@ func buildIssueOverview(ctx *context.Context, unitType unit.Type) {
 			// because the doer may create issues or be mentioned in any public repo.
 			// So we need search issues in all public repos.
 			o.AllPublic = ctx.Doer.ID == ctxUser.ID
-			// TODO: to make it work with poster/assignee filter
+			// TODO: to make it work with poster/assignee filter, then these IDs should be kept
 			o.AssigneeID = nil
 			o.PosterID = nil
+
 			o.MentionID = nil
 			o.ReviewRequestedID = nil
 			o.ReviewedID = nil