Skip to content

Commit 9824001

Browse files
committed
Some improvements
1 parent beea95e commit 9824001

File tree

2 files changed

+3
-10
lines changed

2 files changed

+3
-10
lines changed

models/migrations/v118.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
// Copyright 2019 The Gitea Authors. All rights reserved.
1+
// Copyright 2020 The Gitea Authors. All rights reserved.
22
// Use of this source code is governed by a MIT-style
33
// license that can be found in the LICENSE file.
44

models/review.go

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -420,18 +420,11 @@ func InsertReviews(reviews []*Review) error {
420420
for _, c := range review.Comments {
421421
c.ReviewID = review.ID
422422
}
423-
}
424423

425-
if err := sess.Commit(); err != nil {
426-
return err
427-
}
428-
sess.Close()
429-
430-
for _, review := range reviews {
431-
if _, err := x.NoAutoTime().Insert(review.Comments); err != nil {
424+
if _, err := sess.NoAutoTime().Insert(review.Comments); err != nil {
432425
return err
433426
}
434427
}
435428

436-
return nil
429+
return sess.Commit()
437430
}

0 commit comments

Comments
 (0)