fix and extend test

Author: 6543

models/issues/pull_test.go

@@ -349,13 +349,20 @@ func TestGetApprovers(t *testing.T) {
 	expected := "Reviewed-by: User Five <[email protected]>\nReviewed-by: Org Six <[email protected]>\n"
 	assert.Equal(t, expected, approvers)
 
-	// ( TODO(#35500): dismissed, ) comment-type and pending reviews should be ignored
+	// comment-type and pending reviews should be ignored
+	pr = unittest.AssertExistsAndLoadBean(t, &issues_model.PullRequest{ID: 2})
+	assert.EqualValues(t, 3, pr.IssueID)
+	setting.Repository.PullRequest.DefaultMergeMessageOfficialApproversOnly = false
+	approvers = pr.GetApprovers(t.Context())
+	expected = "Reviewed-by: User Five <[email protected]>\nReviewed-by: user4 <[email protected]>\n"
+	assert.Equal(t, expected, approvers)
+
+	// un-official reviews should now be ignored too
 	pr = unittest.AssertExistsAndLoadBean(t, &issues_model.PullRequest{ID: 2})
 	assert.EqualValues(t, 3, pr.IssueID)
 	setting.Repository.PullRequest.DefaultMergeMessageOfficialApproversOnly = true
 	approvers = pr.GetApprovers(t.Context())
-	expected = "Reviewed-by: User Five <[email protected]>\n" + // TODO(#35500): remove user 5
-		"Reviewed-by: user4 <[email protected]>\n"
+	expected = ""
 	assert.Equal(t, expected, approvers)
 }