[BugFix] remove nil inserts in models

models/migrate.go

@@ -64,15 +64,20 @@ func insertIssue(sess *xorm.Session, issue *Issue) error {
 		})
 		labelIDs = append(labelIDs, label.ID)
 	}
-	if _, err := sess.Insert(issueLabels); err != nil {
-		return err
+	if len(issueLabels) > 0 {
+		if _, err := sess.Insert(issueLabels); err != nil {
+			return err
+		}
 	}
 
 	for _, reaction := range issue.Reactions {
 		reaction.IssueID = issue.ID
 	}
-	if _, err := sess.Insert(issue.Reactions); err != nil {
-		return err
+
+	if len(issue.Reactions) > 0 {
+		if _, err := sess.Insert(issue.Reactions); err != nil {
+			return err
+		}
 	}
 
 	cols := make([]string, 0)
@@ -151,8 +156,10 @@ func InsertIssueComments(comments []*Comment) error {
 			reaction.IssueID = comment.IssueID
 			reaction.CommentID = comment.ID
 		}
-		if _, err := sess.Insert(comment.Reactions); err != nil {
-			return err
+		if len(comment.Reactions) != 0 {
+			if _, err := sess.Insert(comment.Reactions); err != nil {
+				return err
+			}
 		}
 	}
 
@@ -196,12 +203,11 @@ func InsertReleases(rels ...*Release) error {
 			return err
 		}
 
-		for i := 0; i < len(rel.Attachments); i++ {
+		for i, a := range rel.Attachments {
 			rel.Attachments[i].ReleaseID = rel.ID
-		}
-
-		if _, err := sess.NoAutoTime().Insert(rel.Attachments); err != nil {
-			return err
+			if _, err := sess.NoAutoTime().Insert(a); err != nil {
+				return err
+			}
 		}
 	}
 

modules/migrations/gitea.go

@@ -393,18 +393,18 @@ func (g *GiteaLocalUploader) CreateIssues(issues ...*base.Issue) error {
 		iss = append(iss, &is)
 	}
 
-	err := models.InsertIssues(iss...)
-	if err != nil {
-		return err
-	}
 	for _, is := range iss {
+		if err := models.InsertIssues(is); err != nil {
+			return err
+		}
 		g.issues.Store(is.Index, is.ID)
 	}
 	return nil
 }
 
 // CreateComments creates comments of issues
 func (g *GiteaLocalUploader) CreateComments(comments ...*base.Comment) error {
+
 	var cms = make([]*models.Comment, 0, len(comments))
 	for _, comment := range comments {
 		var issueID int64
@@ -478,6 +478,9 @@ func (g *GiteaLocalUploader) CreateComments(comments ...*base.Comment) error {
 		cms = append(cms, &cm)
 	}
 
+	if len(cms) == 0 {
+		return nil
+	}
 	return models.InsertIssueComments(cms)
 }