Skip to content

[ui] Chang icon type for review action in action page #11191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2020
Merged

[ui] Chang icon type for review action in action page #11191

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
34132fd
[ui] Chang icon type for review action in action page
a1012112796 Apr 23, 2020
7335897
Merge branch 'master' into a1012112796-patch-1
a1012112796 Apr 23, 2020
1ac2a3a
Merge branch 'master' into a1012112796-patch-1
a1012112796 Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions modules/templates/helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -557,11 +557,11 @@ func ActionIcon(opType models.ActionType) string {
case models.ActionMirrorSyncPush, models.ActionMirrorSyncCreate, models.ActionMirrorSyncDelete:
return "repo-clone"
case models.ActionApprovePullRequest:
return "eye"
return "check"
case models.ActionRejectPullRequest:
return "x"
return "request-changes"
default:
return "invalid type"
return "question"
}
}

Expand Down