Skip to content

Fix avatar bugs #14217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2021
Merged

Fix avatar bugs #14217

merged 2 commits into from
Jan 2, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Jan 2, 2021 •
edited
Loading

@lunny lunny added the type/bug label Jan 2, 2021
@lunny lunny added this to the 1.14.0 milestone Jan 2, 2021
@codecov-io
Copy link

codecov-io commented Jan 2, 2021 •
edited
Loading

Codecov Report

Merging #14217 (bb3ad6c) into master (e6acce6) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14217      +/-   ##
==========================================
+ Coverage   41.98%   42.00%   +0.01%     
==========================================
  Files         735      735              
  Lines       78881    78880       -1     
==========================================
+ Hits        33121    33130       +9     
+ Misses      40311    40304       -7     
+ Partials     5449     5446       -3
Impacted Files Coverage Δ
models/user_avatar.go 33.33% <50.00%> (-0.88%) ⬇️
services/pull/pull.go 42.28% <0.00%> (ø)
modules/queue/workerpool.go 60.00% <0.00%> (+1.22%) ⬆️
modules/process/manager.go 75.00% <0.00%> (+2.50%) ⬆️
modules/git/tree_entry_nogogit.go 93.75% <0.00%> (+6.25%) ⬆️
modules/util/timer.go 85.71% <0.00%> (+42.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6acce6...bb3ad6c. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 2, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 2, 2021
zeripath
zeripath reviewed Jan 2, 2021
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 2, 2021
@zeripath zeripath merged commit 3abea9e into go-gitea:master Jan 2, 2021
6543 pushed a commit to 6543-forks/gitea that referenced this pull request Jan 2, 2021
@lunny @6543
Fix avatar bugs (go-gitea#14217)
48914fc
@6543 6543 mentioned this pull request Jan 2, 2021
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Jan 2, 2021
@6543
Copy link
Member

6543 commented Jan 3, 2021

Backport: #14220

techknowlogick pushed a commit that referenced this pull request Jan 3, 2021
@6543 @lunny
Fix avatar bugs (#14217) (#14220)
06673cb 
Co-authored-by: Lunny Xiao <[email protected]>
@lunny lunny deleted the lunny/fix_avatar branch January 3, 2021 02:19
This was referenced Jan 3, 2021
Closed
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Feb 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.14.0
Development

Successfully merging this pull request may close these issues.

Organizations avatars are identical
5 participants
@lunny @codecov-io @6543 @zeripath @GiteaBot