Skip to content

[Backport] Fix Deadlock & Delete affected reactions on comment deletion (#14392) #14425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 23, 2021
Merged

[Backport] Fix Deadlock & Delete affected reactions on comment deletion (#14392) #14425

merged 3 commits into from
Jan 23, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Jan 22, 2021 •
edited
Loading

Partial Backport of #14392

  • Fix Deadlock
  • Delete affected reactions on comment deletion

@6543
Enhance Ghost comment mitigation Settings (go-gitea#14392)
9a19979 
* refactor models.DeleteComment and delete related reactions too

* use deleteComment for UserDeleteWithCommentsMaxDays in DeleteUser

* Resolve Fixme & fix potential deadlock
@6543 6543 added the type/bug label Jan 22, 2021
@6543 6543 added this to the 1.13.2 milestone Jan 22, 2021
@6543 6543 changed the title Enhance Ghost comment mitigation Settings (#14392) [Backport] Fix potential Deadlock & Delete affected reactions on comment deletion (#14392) Jan 22, 2021
@6543 6543 mentioned this pull request Jan 22, 2021
Merged
@6543 6543 added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 22, 2021
@6543 6543 changed the title [Backport] Fix potential Deadlock & Delete affected reactions on comment deletion (#14392) [Backport] Fix Deadlock & Delete affected reactions on comment deletion (#14392) Jan 22, 2021
lunny
lunny reviewed Jan 22, 2021
View reviewed changes
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 22, 2021
@6543 6543 removed the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jan 22, 2021
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 22, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 23, 2021
@lunny lunny merged commit 4d2a6c4 into go-gitea:release/v1.13 Jan 23, 2021
@6543 6543 deleted the backport_various-fixes_14392 branch January 23, 2021 02:08
@go-gitea go-gitea locked and limited conversation to collaborators Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.13.2
Development

Successfully merging this pull request may close these issues.
4 participants
@6543 @lunny @zeripath @GiteaBot