Link to existing PR when trying to open a new PR on the same branches #25494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when trying to create a PR for an existing PRs branch combination link to the PR directly and not just to the repo.
GiteaBot
added
the
lgtm/need 2
delvh
changed the title
|
I think there is already a button there |
wxiaoguang
approved these changes
Jun 25, 2023
GiteaBot
added
lgtm/need 1
Yes there is a button, but currently the link does only point to the repo. As the link shows the number of the existing pr it looks like it will open the existing PR. In my opinion this is not intuitive for the user. |
lunny
approved these changes
Jun 25, 2023
GiteaBot
added
lgtm/done
lunny
added
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when trying to create a PR for an existing PRs branch combination link to the PR directly and not just to the repo.
Before:
After:
