Skip to content

A file that is both unprotected and protected is unprotected #26861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

A file that is both unprotected and protected is unprotected #26861

wants to merge 15 commits into from

Conversation

@lunny
Copy link
Member

@lunny lunny commented Sep 1, 2023

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 1, 2023
@lunny lunny added kind/bugfix and removed type/bug labels Oct 7, 2023
@delvh delvh added type/bug and removed kind/bugfix labels Oct 7, 2023
@delvh delvh changed the title Fix unprotected files check bug A file that is both unprotected and protected is unprotected Oct 21, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 21, 2023
@denyskon denyskon added the giteabot/update-branch Hint for the bot that it should update a PR with the latest state on main label Dec 25, 2023
@GiteaBot GiteaBot removed the giteabot/update-branch Hint for the bot that it should update a PR with the latest state on main label Dec 25, 2023
@denyskon denyskon self-requested a review December 25, 2023 19:47
@denyskon
Copy link
Member

denyskon commented Dec 25, 2023

@lunny The test failures seem related. Could you take a look?

@lunny lunny added this to the 1.22.0 milestone Dec 30, 2023
@lunny
Copy link
Member Author

lunny commented Dec 30, 2023

@lunny The test failures seem related. Could you take a look?

The test fixture is conflicted. I have fixed the new test fixture.

@denyskon
Copy link
Member

denyskon commented Feb 24, 2024

@lunny Still no luck here seemingly.... could you try again to fix it?

@lunny lunny marked this pull request as draft March 4, 2024 08:06
@lunny lunny modified the milestones: 1.22.0, 1.23.0 Mar 4, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 17, 2024
@lunny lunny removed this from the 1.23.0 milestone Sep 7, 2024
@lunny lunny closed this Mar 14, 2025
@lunny
Copy link
Member Author

lunny commented Mar 14, 2025

Close as outdated.

@lunny lunny deleted the lunny/fix_unprotected_files_bug branch March 14, 2025 19:55
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@delvh delvh delvh approved these changes

@denyskon denyskon Awaiting requested review from denyskon

Assignees

No one assigned

Labels

lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@lunny @denyskon @delvh @GiteaBot