Skip to content

Valid email address should only start with alphanumeric #28174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 20, 2025
Merged

Valid email address should only start with alphanumeric #28174

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
bb7ed04
This fixes issue #27847
dek5troza Nov 22, 2023
f6d7de1
Fixes #27847
dek5troza Nov 23, 2023
ead4a99
Merge branch 'main' into issue-27847
dek5troza Nov 23, 2023
d863bc7
Merge branch 'main' into issue-27847
dek5troza Nov 24, 2023
e92ea5a
Merge branch 'main' into issue-27847
dek5troza Nov 27, 2023
b6d9849
Fix failing go fmt check
dek5troza Nov 27, 2023
bbb73ff
Merge branch 'main' into issue-27847
dek5troza Nov 27, 2023
1ca8944
Merge branch 'main' into issue-27847
wxiaoguang Apr 20, 2025
93c39b1
fix
wxiaoguang Apr 20, 2025
e6620a3
more test cases
wxiaoguang Apr 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/markup/html.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ var (
// well as the HTML5 spec:
// http://spec.commonmark.org/0.28/#email-address
// https://html.spec.whatwg.org/multipage/input.html#e-mail-state-(type%3Demail)
emailRegex = regexp.MustCompile("(?:\\s|^|\\(|\\[)([a-zA-Z0-9.!#$%&'*+\\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\\.[a-zA-Z0-9]{2,}(?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)+)(?:\\s|$|\\)|\\]|;|,|\\?|!|\\.(\\s|$))")
emailRegex = regexp.MustCompile("(?:\\s|^|\\(|\\[)([a-zA-Z0-9][a-zA-Z0-9.!#$%&'*+\\/=?^_`{|}~-]+@[a-zA-Z0-9](?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?(?:\\.[a-zA-Z0-9]{2,}(?:[a-zA-Z0-9-]{0,61}[a-zA-Z0-9])?)+)(?:\\s|$|\\)|\\]|;|,|\\?|!|\\.(\\s|$))")

// blackfriday extensions create IDs like fn:user-content-footnote
blackfridayExtRegex = regexp.MustCompile(`[^:]*:user-content-`)
Expand Down
8 changes: 8 additions & 0 deletions modules/markup/html_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,14 @@ func TestRender_email(t *testing.T) {
test(
"[email protected]:go-gitea/gitea.git",
`<p>[email protected]:go-gitea/gitea.git</p>`)
test(
"[email protected]",
`<p>[email protected]</p>`)
test(
"[email protected]",
`<p>[email protected]</p>`)
test("*[email protected]",
`<p>*[email protected]</p>`)
test(
"gitea@3",
`<p>gitea@3</p>`)
Expand Down