Merge api on Create or update file contents #29419
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
the
modifies/api
lunny
reviewed
Feb 26, 2024
smallfish06
force-pushed
the
main
branch
3 times, most recently
from
0e047e0 to
0f2cc99
Compare
smallfish06
commented
Feb 26, 2024
Comment on lines
+726
to
+730
| if apiOpts.SHA == "" { | ||
| ctx.JSON(http.StatusCreated, fileResponse) | ||
| } else { | ||
| ctx.JSON(http.StatusOK, fileResponse) | ||
| } |
There was a problem hiding this comment.
This part looks bit awkward to use SHA as flag of response. If you have any idea for this please let me know
I tried using file_service.GetContents to make clear for this but couldn't get more understandable code
There was a problem hiding this comment.
Instead of using fragile "SHA" field, using a new "operation" is better.
Now:
- create: for non-existing file
- update: for existing file
- upload: create or update
smallfish06
commented
Feb 27, 2024
| // required: true | ||
| // schema: | ||
| // "$ref": "#/definitions/UpdateFileOptions" | ||
| // "$ref": "#/definitions/ApplyDiffPatchFileOptions" |
There was a problem hiding this comment.
Swagger doc was using wrong schema
There was a problem hiding this comment.
Fixed by Fix diffpatch API endpoint (#35610)
lunny
reviewed
Feb 27, 2024
| } | ||
| } | ||
|
|
||
| func getExpectedFileResponseForCreate(repoFullName, commitID, treePath, latestCommitSHA string) *api.FileResponse { |
There was a problem hiding this comment.
Why delete these functions and tests?
There was a problem hiding this comment.
Duplicate code and testing. Same function and test are in api_repo_file_create_or_update_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to (#19008).
After this PR merged, CreateFile API get deprecated and UpdateFile became CreateAndUpdateFile. Also some signature changed.
Added another PR on https://gitea.com/gitea/go-sdk/pulls/652, connected with this PR