Fix login with oauth2 sometimes return could not find a matching session for this request
#32149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion for this request
GiteaBot
added
the
lgtm/need 2
lunny
changed the title
could not find a matching session for this request
wxiaoguang
reviewed
Sep 29, 2024
|
|
||
| log.Error("OAuth2 Provider %s error(start BeginAuthHandler): %v", authSource.Name, err) | ||
| gothic.BeginAuthHandler(response, request) | ||
| return nil, goth.User{}, nil |
There was a problem hiding this comment.
That's really a hacky patch and I do not think it is right.
- Gitea never calls BeginAuthHandler directly
- It might cause infinite redirection
There was a problem hiding this comment.
This is from the official example https://github.com/markbates/goth/blob/master/examples/main.go#L250-L258 and I have tested it many times manually, and it works.
There was a problem hiding this comment.
Yup, it is official, but it is not right.
There was a problem hiding this comment.
I have tested it many times manually, and it works.
How did you test? What if your "test" is wrong.
I do not see how it fixes 27033 |
|
OK. This is a mistake. The real problem is users visiting a Gitea address which is not the one they input in the GitHub oauth2 application forms. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix #27033
#5551