Fix javascript error when an anonymous user visiting migration page (#32144) #32179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-gitea#32144) This PR fixes javascript errors when an anonymous user visits the migration page. It also makes task view checking more restrictive. The router moved from `/user/task/{id}/status` to `/username/reponame/-/migrate/status` because it's a migrate status. --------- Co-authored-by: wxiaoguang <[email protected]>
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/go
|
Hey i can solve this problem and want to contribute. Can you please explain me more about it? |
This is a backport pull request. Do you want to review it? |
yp05327
approved these changes
Oct 3, 2024
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
Oct 4, 2024
GiteaBot
added
lgtm/done
techknowlogick
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
|
Maybe related: Missing redirects after mirroring new project #32231 Update: Unable to reproduce (tried on 1.23 and 1.22) The page gets correctly reloaded after the migration finishes. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #32144
This PR fixes javascript errors when an anonymous user visits the migration page.
It also makes task view checking more restrictive.
The router moved from
/user/task/{id}/statusto/username/reponame/-/migrate/statusbecause it's a migrate status.