Skip to content

Fix bug when a token is given public only #32204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 8, 2024
Merged

Fix bug when a token is given public only #32204

merged 15 commits into from
Oct 8, 2024

Conversation

@lunny
Copy link
Member

@lunny lunny commented Oct 6, 2024

No description provided.

@lunny lunny added the type/bug label Oct 6, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 6, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Oct 6, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 6, 2024
yp05327
yp05327 reviewed Oct 7, 2024
View reviewed changes
@lunny lunny mentioned this pull request Oct 7, 2024
Merged
@yp05327 yp05327 added this to the 1.23.0 milestone Oct 7, 2024
@lunny lunny self-assigned this Oct 7, 2024
@lunny lunny marked this pull request as draft October 7, 2024 22:30
@lunny lunny marked this pull request as ready for review October 8, 2024 00:56
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 8, 2024
yp05327
yp05327 reviewed Oct 8, 2024
View reviewed changes
yp05327
yp05327 reviewed Oct 8, 2024
View reviewed changes
yp05327
yp05327 reviewed Oct 8, 2024
View reviewed changes
@lafriks lafriks merged commit d6d3c96 into go-gitea:main Oct 8, 2024
26 checks passed
@GiteaBot
Copy link
Collaborator

GiteaBot commented Oct 8, 2024

I was unable to create a backport for 1.22. @lunny, please send one manually. 🍵

go run ./contrib/backport 32204
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Oct 8, 2024
@lunny lunny deleted the lunny/fix_public_only_scope branch October 8, 2024 17:27
lunny added a commit to lunny/gitea that referenced this pull request Oct 8, 2024
@lunny
Fix bug when a token is given public only (go-gitea#32204)
4d0547e
@lunny lunny mentioned this pull request Oct 8, 2024
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Oct 8, 2024
lunny added a commit that referenced this pull request Oct 9, 2024
@lunny
Fix bug when a token is given public only (#32204) (#32218)
56051d9 
Backport #32204
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 10, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
581f19f 
* giteaofficial/main:
  Refactor CSRF token (go-gitea#32216)
  [skip ci] Updated translations via Crowdin
  Fix incorrect "Target branch does not exist" in PR title (go-gitea#32222)
  update git book link to v2 (go-gitea#32221)
  [skip ci] Updated translations via Crowdin
  Add null check for responseData.invalidTopics (go-gitea#32212)
  Fix bug when a token is given public only (go-gitea#32204)
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Oct 11, 2024
@lunny @earl-warren
Fix bug when a token is given public only
a052d2b 
Port of go-gitea/gitea#32204

(cherry picked from commit d6d3c96e6555fc91b3e2ef21f4d8d7475564bb3e)

Conflicts:
  routers/api/v1/api.go
	services/context/api.go
  trivial context conflicts
@wxiaoguang wxiaoguang mentioned this pull request Oct 11, 2024
Closed
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Oct 11, 2024
@lunny @earl-warren
Fix bug when a token is given public only
ea5a8c7 
Port of go-gitea/gitea#32204

(cherry picked from commit d6d3c96e6555fc91b3e2ef21f4d8d7475564bb3e)

Conflicts:
  routers/api/v1/api.go
	services/context/api.go
  trivial context conflicts
(cherry picked from commit a052d2b)

Conflicts:
	routers/api/v1/user/user.go
  trivial context conflict (search by email is not in v9.0)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@yp05327 yp05327 yp05327 left review comments

@lafriks lafriks lafriks approved these changes

@delvh delvh delvh approved these changes

+1 more reviewer

@Zettat123 Zettat123 Zettat123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lunny lunny

Labels

backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

1.23.0

Development

Successfully merging this pull request may close these issues.

6 participants

@lunny @GiteaBot @lafriks @Zettat123 @yp05327 @delvh