Skip to content

Save gitea specific settings for vscode #32279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Save gitea specific settings for vscode #32279

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d73be9f
save preoject specific settings for vscode
6543 Oct 16, 2024
c56d2a4
Merge branch 'main' into vscode-make-tests-work
6543 Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,10 @@ _test
/gitea_*

# MS VSCode
.vscode
.vscode/*
!.vscode/settings.json
!.vscode/launch.json
!.vscode/extensions.json
Comment on lines +17 to +20
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
.vscode/*
!.vscode/settings.json
!.vscode/launch.json
!.vscode/extensions.json
.vscode

The gitignore could be kept as-is. It doesn't affected the manually added files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes but this is the more compliant way!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think it is more compliant. Instead it just makes thing more complicated.

By using a single .vscode, everything just works well, and the manually added files are always correctly handled.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still prefer to only keep the one line .vscode just like the old

__debug_bin*

*.cgo1.go
Expand Down
3 changes: 3 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This configuration already exists in the contrib/ide/vscode/settings.json

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, only need to keep one

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the pr is not necessary

Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"go.buildTags": "sqlite,sqlite_unlock_notify",
}