-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
Add new index for action to resolve the performance problem #32333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c72d24a
Add new index for action to resolve the performance problem
lunny 3cc7fc5
Merge branch 'main' into lunny/add_index_action
lunny aa85a4c
Merge branch 'main' into lunny/add_index_action
lunny a3778dc
Merge branch 'main' into lunny/add_index_action
GiteaBot b33859f
Merge branch 'main' into lunny/add_index_action
GiteaBot e73d244
Merge branch 'main' into lunny/add_index_action
GiteaBot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| // Copyright 2024 The Gitea Authors. All rights reserved. | ||
| // SPDX-License-Identifier: MIT | ||
|
|
||
| package v1_23 //nolint | ||
|
|
||
| import ( | ||
| "code.gitea.io/gitea/modules/timeutil" | ||
|
|
||
| "xorm.io/xorm" | ||
| "xorm.io/xorm/schemas" | ||
| ) | ||
|
|
||
| type improveActionTableIndicesAction struct { | ||
| ID int64 `xorm:"pk autoincr"` | ||
| UserID int64 `xorm:"INDEX"` // Receiver user id. | ||
| OpType int | ||
| ActUserID int64 // Action user id. | ||
| RepoID int64 | ||
| CommentID int64 `xorm:"INDEX"` | ||
| IsDeleted bool `xorm:"NOT NULL DEFAULT false"` | ||
| RefName string | ||
| IsPrivate bool `xorm:"NOT NULL DEFAULT false"` | ||
| Content string `xorm:"TEXT"` | ||
| CreatedUnix timeutil.TimeStamp `xorm:"created"` | ||
| } | ||
|
|
||
| // TableName sets the name of this table | ||
| func (*improveActionTableIndicesAction) TableName() string { | ||
| return "action" | ||
| } | ||
|
|
||
| func (a *improveActionTableIndicesAction) TableIndices() []*schemas.Index { | ||
| repoIndex := schemas.NewIndex("r_u_d", schemas.IndexType) | ||
| repoIndex.AddColumn("repo_id", "user_id", "is_deleted") | ||
|
|
||
| actUserIndex := schemas.NewIndex("au_r_c_u_d", schemas.IndexType) | ||
| actUserIndex.AddColumn("act_user_id", "repo_id", "created_unix", "user_id", "is_deleted") | ||
|
|
||
| cudIndex := schemas.NewIndex("c_u_d", schemas.IndexType) | ||
| cudIndex.AddColumn("created_unix", "user_id", "is_deleted") | ||
|
|
||
| cuIndex := schemas.NewIndex("c_u", schemas.IndexType) | ||
| cuIndex.AddColumn("user_id", "is_deleted") | ||
|
|
||
| indices := []*schemas.Index{actUserIndex, repoIndex, cudIndex, cuIndex} | ||
|
|
||
| return indices | ||
| } | ||
|
|
||
| func AddNewIndexForUserDashboard(x *xorm.Engine) error { | ||
| return x.Sync(new(improveActionTableIndicesAction)) | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.