- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6.2k
feat: allow commemting on unchanged lines #32354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow commemting on unchanged lines #32354
Conversation
Signed-off-by: Divanshu Grover <[email protected]>
Signed-off-by: Divanshu Grover <[email protected]>
| You still need to consider those lines that async loading. | 
| @lunny can you please help because I'm having hard time understanding the codebase. | 
| 
 Some code lines are hidden before you click the icon like below So for these lines, maybe we want to add comments on these lines. This is the hardest part of this issue. | 
| @lunny after the user adds the comments , the comments get stored in database , but when the page reloads the template is regenerated and we are not able to see those comments but when we again do add comments on those lines , we always see those coments which ware previosly added by the user | 
| 
 That's the problem. If one adds comments on hidden lines, others don't know there are comments there except he click the expand icons. I think we have two options. One is to expand those lines which have comments but this is very complicated. Another is to add some icons or indications that there are comments on these hidden code lines. | 
| If you search  | 




Adds support for commenting on unchanged lines (Expanded lines)
/claim #32257
Closes #32257