- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 6.2k
Fix a number of typescript issues #32459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
                
     Merged
            
            
          Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    yardenshoham
  
              
              approved these changes
              
                  
                    Nov 9, 2024 
                  
              
              
            
            
              
                    wxiaoguang
  
              
              reviewed
              
                  
                    Nov 9, 2024 
                  
              
              
            
            
              
                    delvh
  
              
              approved these changes
              
                  
                    Nov 9, 2024 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from @wxiaoguang's comment LGTM
              
                    silverwind
  
              
              commented
              
                  
                    Nov 11, 2024 
                  
              
              
            
            
    
  zjjhot 
      added a commit
        to zjjhot/gitea
      that referenced
      this pull request
    
      Nov 13, 2024 
    
    
      
  
    
      
    
  
* giteaofficial/main: Disable Oauth check if oauth disabled (go-gitea#32368) Update JS and PY dependencies (go-gitea#32482) Update `github.com/meilisearch/meilisearch-go` (go-gitea#32484) Fix test fixtures for user2/lfs.git (go-gitea#32477) Limit org member view of restricted users (go-gitea#32211) cargo registry - respect renamed dependencies (go-gitea#32430) Refactor LFS SSH and internal routers (go-gitea#32473) Fix a number of typescript issues (go-gitea#32459) Harden runner updateTask and updateLog api (go-gitea#32462) Move some functions from issue.go to standalone files (go-gitea#32468)
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      Labels
      
    lgtm/done
  This PR has enough approvals to get merged. There are no important open reservations anymore. 
  
    modifies/frontend
  
    type/refactoring
  Existing code has been cleaned up. There should be no new functionality. 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Fixes 69 typescript errors found in the
adminandmarkupfolders.